forked from reingart/pyfpdf
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write() refactor to use new line wrapping code #346
Merged
Merged
Changes from 9 commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
71bd53d
Fix parsing of csv template files
gmischler d70bc37
fixes suggested by static code check
gmischler 6ed9686
Update template.py
gmischler fa62a8d
now it's dark.
gmischler f1d7802
do some hardcoded template tests without multiline
gmischler ec69b8f
first round Splitting Template() into FlexTemplate()
gmischler 6771592
offset and rotate for render(), first test
gmischler 536e819
small fixes and cleanup
gmischler 42e0d27
removing mistaken checkin
gmischler 5b1d889
test for multipage Template(); Template.code39 with standard template…
gmischler 92c9e28
refer defaults to type handlers, x2 optional for barcodes
gmischler 0195db4
more template and flextemplate tests
gmischler bb97a63
Merge remote-tracking branch 'upstream/master'
gmischler e5ab09c
static check fixes
gmischler fdb03de
more pylint
gmischler 56f639e
blackity-black
gmischler bef03d1
even blacker
gmischler cad0264
Expand docstrings, update help, hide private methods.
gmischler 0f99984
Issues from PR review
gmischler 1af4365
Merge remote-tracking branch 'upstream/master'
gmischler bba1ca1
Issue #226 solved: Rotate anything anywhere
gmischler b89147a
Issue #238 solved - split_multicell doesn't modify target document
gmischler 13e9739
Documentation details and corrections
gmischler 058f7ea
breaking up long line
gmischler 5807548
rotation fix slightly changed barcode output
gmischler 557148a
Update CHANGELOG.md
gmischler ddba2ce
Include _write() in template rotation test
gmischler 4847792
FlexTemplate.render() with scaling
gmischler 6f2c98f
empty text field - consistency between T and W
gmischler 2b2d82e
Enforce user input types as early as possible
gmischler b00666d
Merge remote-tracking branch 'upstream/master'
gmischler ba9ab80
Fix to make sure deprecated code39 arguments still work
gmischler a746ef7
sync to upstream
gmischler 7c9fcdb
some more test coverage
gmischler 03814bb
pylint asking for style points...
gmischler d09688c
picky black...
gmischler f8febaa
Merge branch 'PyFPDF:master' into master
gmischler 546d5b2
Merge remote-tracking branch 'upstream/master'
gmischler 294287c
Change background default to transparent
gmischler 431d918
Add ellipse element to templates
gmischler 753c246
Bugfix skipping check for x2 with barcods
gmischler 112f496
More template tests
gmischler d5de0e2
code cleanup
gmischler 605acb1
list template changes to log
gmischler a256212
expose FlexTemplate through __init__.__all__
gmischler de230b8
Merge remote-tracking branch 'upstream/master'
gmischler 2582afb
bugfix: Keep track of nested rotation contexts
gmischler a6501f3
test fix: text file loaded in binary mode
gmischler f26a873
new set_dash_pattern(); dashed_line() retired
gmischler 325566c
Merge remote-tracking branch 'upstream/master'
gmischler bae8b76
test update for deprecated dashed_line()
gmischler 007e00b
mask unused argument in test
gmischler a96bcc3
error message fix, expand test coverage
gmischler b04c879
updates based on PR review
gmischler 41672c5
Merge remote-tracking branch 'upstream/master'
gmischler f5573ef
Graphics state stack implemented, rotation fixed
gmischler fec5188
Simplify Templates again, making use of flexible rotation
gmischler c201180
code cleanup
gmischler cdcdf37
Merge remote-tracking branch 'upstream/master'
gmischler f4f2dd0
merging updates from upstream
gmischler 35df15b
Update flextemplate_rotation.pdf
gmischler 6c46a5f
Merge remote-tracking branch 'upstream/master'
gmischler 5ebb144
Updating changelog
gmischler e1299a2
Merge remote-tracking branch 'upstream/master'
gmischler 604a6b0
include line_width in graphics context stack
gmischler 29c4266
hopefully fixing line endings
gmischler 516be96
changes discussed in PR review
gmischler 18bd976
migrating test_regular_polygon.py to standard fixture
gmischler 5747acc
Merge branch 'PyFPDF:master' into master
gmischler e8507ec
Merge branch 'PyFPDF:master' into master
gmischler f24a4cf
Merge branch 'PyFPDF:master' into master
gmischler 99a03a8
initial working write() refactor
gmischler 0d90739
replace ln=0 internally with newpos_x/newpos_y
gmischler 6e68780
renaming test/cells to test/text, moving rext related tests there
gmischler 2c85c61
test cases for write() and _render_styled_cell_text()
gmischler 427b61b
Move word spacing code to _render_styled_cell_text()
gmischler 27b85f4
Merge branch 'PyFPDF:master' into master
gmischler fb7dfac
Merge branch 'PyFPDF:master' into write_refactor
gmischler c7d911b
print_sh option for write() and multi_cell()
gmischler 2774b24
Merge branch 'write_refactor' of https://github.com/gmischler/fpdf2 i…
gmischler ff3b19a
tabs to spaces
gmischler 5884cc8
Apply PR review
gmischler c99ac7d
Merge branch 'PyFPDF:master' into master
gmischler 155f758
Merge branch 'master' into write_refactor
gmischler baee4b7
merge origin updates
gmischler ce2fc7c
newpos_[xy] to new[xy], annotations, docstring fixes
gmischler 3a72364
revert drawing.py, after black 22.1 made up its mind
gmischler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really short for a class name...
It's not good if you read
from fpdf import X, Y
and you really don't know what are thoseX
&Y
objects!I suggest to rename those enums
XAlign
&YAlign
.What do you think @gmischler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point. They're not really alignments, though...
XPos
&YPos
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'm fine with that!