-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix artefact on line junctions when calling arc()
#492
Conversation
Use operator `h` when both `start_from_center` and `end_at_center` are True otherwise use the previous operator (`l`).
@all-contributors please add @Jmillan-Dev for code |
I've put up a pull request to add @Jmillan-Dev! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thank you for contributing 😊
Seems like some unit tests are now failing:
Can you reproduce this on your computer with I you check the source code of the If my explanations are not very clear to you, feel free to ask any questions and I'll try to make things clearer 😊 |
Okay, I forget to change the new test PDF file for And I now have updated all of the |
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
==========================================
- Coverage 92.11% 91.96% -0.16%
==========================================
Files 23 23
Lines 6682 6555 -127
Branches 1365 1333 -32
==========================================
- Hits 6155 6028 -127
Misses 299 299
Partials 228 228
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This looks great! Merging now |
Fixes #488
By using the operator
h
when bothstart_from_center
andend_at_center
are True fixes the rendering issue.This closes the path of the shape instead of leaving it open like
l
did before.Tests have been added to check this new behavior.
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
A mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.