-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #632: <img> without "height" attribute fails to leave enough blank space for itself #634
Conversation
Some memory checks are currently failing in the CI pipeline. |
Ok, I can fix it. Here's another problem. |
I'm 100% OK with removing the decoded bytes from the What makes you think this behaviour of |
I first tried reserving
In the original code, the return value of |
Hi and Merry Christmas @Bubbu0129 😄 The performance tests heavily depend on your computer caracteristics:
OK, I think I understand your analysis, thank you for explaining. I bet that even when returning the FYI, I'm investigating
What do you mean exactly? Currently their is no part of Could you please rebase your PR on this repo |
OK, I see. |
Codecov ReportBase: 93.96% // Head: 93.96% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #634 +/- ##
=======================================
Coverage 93.96% 93.96%
=======================================
Files 25 25
Lines 6457 6460 +3
Branches 1156 1156
=======================================
+ Hits 6067 6070 +3
Misses 223 223
Partials 167 167
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Merged! Thank you 😄 |
Fixes #632
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
A mention of the change is present in
CHANGELOG.md
The unit test
test_img_inside_html_table_without_explicit_dimensions
intest_html.py
isn't passed. The outcome and the original pdf looks identical, but the bytes are different somehow. Can you check it for me?By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.