Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPDF.image(), when provided a BytesIO instance, does not close it any more - fix #881 #887

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Aug 13, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (978db12) 93.25% compared to head (2911f05) 93.25%.

❗ Current head 2911f05 differs from pull request most recent head b366d09. Consider uploading reports for the commit b366d09 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #887   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files          27       27           
  Lines        7680     7682    +2     
  Branches     1395     1395           
=======================================
+ Hits         7162     7164    +2     
  Misses        327      327           
  Partials      191      191           
Files Changed Coverage Δ
fpdf/image_parsing.py 84.03% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lucas-C Lucas-C merged commit 319b8f1 into master Aug 13, 2023
10 checks passed
@Lucas-C Lucas-C deleted the issue-881 branch August 13, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants