Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROB: cope with missing /W entry (#1134) #1136

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Conversation

pubpub-zz
Copy link
Collaborator

robustness issue identified in #1134

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #1136 (51fe3b4) into main (f2983e1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 51fe3b4 differs from pull request most recent head 138d08f. Consider uploading reports for the commit 138d08f to get more accurate results

@@           Coverage Diff           @@
##             main    #1136   +/-   ##
=======================================
  Coverage   92.03%   92.04%           
=======================================
  Files          24       24           
  Lines        4671     4674    +3     
  Branches      965      965           
=======================================
+ Hits         4299     4302    +3     
  Misses        227      227           
  Partials      145      145           
Impacted Files Coverage Δ
PyPDF2/_cmap.py 93.84% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2983e1...138d08f. Read the comment docs.

PyPDF2/_cmap.py Outdated Show resolved Hide resolved
@pubpub-zz pubpub-zz mentioned this pull request Jul 20, 2022
Co-authored-by: Martin Thoma <[email protected]>
@MartinThoma MartinThoma merged commit fd00f20 into py-pdf:main Jul 20, 2022
@MartinThoma
Copy link
Member

You're having a streak! I wish I could do something similar to the Unreal Turnament games for killing bugs - MEGA Kill - ULTRA Kill - ... 😄

MartinThoma added a commit that referenced this pull request Jul 21, 2022
New Features (ENH):
-  Add `outline_count` property (#1129)

Bug Fixes (BUG):
-  Make reader.get_fields also return dropdowns with options (#1114)
-  Add deprecated EncodedStreamObject functions back until PyPDF2==3.0.0 (#1139)

Robustness (ROB):
-  Cope with missing /W entry (#1136)
-  Cope with invalid parent xref (#1133)

Documentation (DOC):
-  Contributors file (#1132)
-  Fix type in signature of PdfWriter.add_uri (#1131)

Developer Experience (DEV):
-  Add .git-blame-ignore-revs (#1141)

Code Style (STY):
-  Fixing typos (#1137)
-  Re-use code via get_outlines_property in tests (#1130)

Full Changelog: 2.6.0...2.7.0
@pubpub-zz pubpub-zz deleted the iss1134 branch August 8, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants