Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: accepts ETen-B5 and UniCNS-UTF16 encodings #2721

Merged
merged 2 commits into from
Jun 23, 2024
Merged

ENH: accepts ETen-B5 and UniCNS-UTF16 encodings #2721

merged 2 commits into from
Jun 23, 2024

Conversation

pubpub-zz
Copy link
Collaborator

@pubpub-zz pubpub-zz commented Jun 21, 2024 •
edited by stefan6419846
Loading

Related to #2356

@stefan6419846
Copy link
Collaborator

There are three aspects I am not sure about:

  • Do we really need the TBC comments inside the mapping?
  • If we have possibly public PDF files, shouldn't we add at least a basic test.
  • We should not close PdfReader - Extract images from specific pages #2536 with this - there are still unsupported encodings left, as indicated by the "TBC" comments as well.

@pubpub-zz
Copy link
Collaborator Author

There are three aspects I am not sure about:

* Do we really need the `TBC` comments inside the mapping?

The TBC are just here to wait from feed back from @actuary-chen

* If we have possibly public PDF files, shouldn't we add at least a basic test.

I did not focus as this should not be easily subject to regressio on it but I agree it should be better

* We should not close [PdfReader - Extract images from specific pages #2536](https://github.com/py-pdf/pypdf/discussions/2536) with this - there are still unsupported encodings left, as indicated by the "TBC" comments as well.

I dislike the Idea of having a garbage collecting issue on this subject : We need to have some test file to confirm the proper encoding; I prefer new issue to raised on case per case.

@pubpub-zz
Copy link
Collaborator Author

I'veremoved all TBC. Let's wait a litte for some feedbacks from @actuary-chen for the last entries

@codecov Codecov
Copy link

codecov bot commented Jun 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (a512408) to head (fdbf37c).
Report is 66 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2721   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          51       51           
  Lines        8547     8547           
  Branches     1703     1703           
=======================================
  Hits         8132     8132           
  Misses        261      261           
  Partials      154      154

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

I dislike the Idea of having a garbage collecting issue on this subject : We need to have some test file to confirm the proper encoding; I prefer new issue to raised on case per case.

I initially opened the corresponding issue to discuss how this could be done in general or whether there might be any official test documents which would allow us to cover all cases without having lots of small commits for it.

@actuary-chen
Copy link

actuary-chen commented Jun 22, 2024 via email

@actuary-chen
Copy link

actuary-chen commented Jun 23, 2024 via email

@stefan6419846 stefan6419846 merged commit 81f35f9 into py-pdf:main Jun 23, 2024
17 checks passed
@pubpub-zz pubpub-zz deleted the iss2356 branch June 23, 2024 09:27
stefan6419846 added a commit that referenced this pull request Jun 23, 2024
@stefan6419846
REL: 4.3.0
d3ef5e5 
## What's new

### New Features (ENH)
- Accept ETen-B5 and UniCNS-UTF16 encodings (#2721) by @pubpub-zz
- Add decode_as_image() to ContentStreams (#2615) by @pubpub-zz
- context manager for PdfReader (#2666) by @tibor-reiss
- Add capability to set font and size in fields (#2636) by @pubpub-zz
- Allow to pass input file without named argument (#2576) by @pubpub-zz

### Bug Fixes (BUG)
- Fix deprecation for Ressources when using old constants (#2705) by @stefan6419846
- Fix images issue 4 bits encoding and LUT starting with UTF16_BOM (#2675) by @pubpub-zz
- Reading large compressed images takes huge time to process (#2644) by @snanda85
- Highlighted Text Cannot Be Printed (#2604) by @Nifury
- Fix UnboundLocalError on malformed pdf (#2619) by @farjasju

### Documentation (DOC)
- Various improvements on docstrings and examples by @j-t-1

### Robustness (ROB)
- Cope with missing Standard 14 fonts in fields (#2677) by @pubpub-zz
- Improve inline image extraction (#2622) by @pubpub-zz
- Cope with loops in Fields tree (#2656) by @pubpub-zz
- Discard /I in choice fields for compatibility with Acrobat (#2614) by @pubpub-zz
- Cope with some issues in pillow (#2595) by @pubpub-zz
- Cope with some image extraction issues (#2591) by @pubpub-zz

### Maintenance (MAINT)
- Deprecate interiour_color with replacement interior_color (#2706) by @j-t-1
- Add deprecate_with_replacement to PdfWriter.find_bookmark (#2674) by @j-t-1

### Code Style (STY)
- Change Link to be a non-markup annotation (#2714) by @j-t-1

[Full Changelog](4.2.0...4.3.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan6419846 stefan6419846 stefan6419846 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pubpub-zz @stefan6419846 @actuary-chen