Enable Python 3.8 support #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbattocchi
force-pushed
the
kebatt/python38
branch
from
d08827e
to
aba52bb
Compare
|
Abandoning this for now because tensorflow won't support Python 3.8 until version 2.2 sometime later this year, and we're limiting to tensorflow 1.* for now anyway. |
|
Tensorflow 2.2 will soon be out, so I'm reopening this so that we can support Python 3.8, which has been out for several months and is seeing increased use in practice. |
kbattocchi
force-pushed
the
kebatt/python38
branch
2 times, most recently
from
2b7af86
to
954ef4c
Compare
kbattocchi
force-pushed
the
kebatt/python38
branch
from
954ef4c
to
54f531b
Compare
kbattocchi
force-pushed
the
kebatt/python38
branch
from
6495632
to
ba1446c
Compare
kbattocchi
force-pushed
the
kebatt/python38
branch
from
ba1446c
to
b4be8af
Compare
kbattocchi
force-pushed
the
kebatt/python38
branch
from
b4be8af
to
d16e0bb
Compare
kbattocchi
force-pushed
the
kebatt/python38
branch
from
d16e0bb
to
fcf11c2
Compare
kbattocchi
force-pushed
the
kebatt/python38
branch
6 times, most recently
from
58fdc9f
to
7fc79fc
Compare
kbattocchi
force-pushed
the
kebatt/python38
branch
from
7fc79fc
to
9835a06
Compare
kbattocchi
force-pushed
the
kebatt/python38
branch
from
9835a06
to
1e29f6d
Compare
kbattocchi
force-pushed
the
kebatt/python38
branch
2 times, most recently
from
774a1ba
to
e9d49ba
Compare
kbattocchi
force-pushed
the
kebatt/python38
branch
from
e9d49ba
to
853b5fc
Compare
kbattocchi
commented
Aug 10, 2020
Comment on lines
+106
to
+139
| # - job: 'AutoML' | ||
| # dependsOn: 'EvalChanges' | ||
| # condition: eq(dependencies.EvalChanges.outputs['output.testCode'], 'True') | ||
| # variables: | ||
| # python.version: '3.6' | ||
| # pool: | ||
| # vmImage: 'ubuntu-16.04' | ||
| # steps: | ||
| # - template: azure-pipelines-steps.yml | ||
| # parameters: | ||
| # body: | ||
| # - task: AzureCLI@2 | ||
| # displayName: 'AutoML tests' | ||
| # inputs: | ||
| # azureSubscription: 'automl' | ||
| # scriptLocation: 'inlineScript' | ||
| # scriptType: 'pscore' | ||
| # powerShellIgnoreLASTEXITCODE: '' # string for now due to https://github.com/microsoft/azure-pipelines-tasks/issues/12266 | ||
| # inlineScript: | | ||
| # $env:SUBSCRIPTION_ID = az account show --query id -o tsv | ||
| # python setup.py pytest | ||
| # env: | ||
| # WORKSPACE_NAME: 'testWorkspace' | ||
| # RESOURCE_GROUP: 'testingAutoMLEconML' | ||
| # PYTEST_ADDOPTS: '-m "automl" -n 0' | ||
| # COVERAGE_PROCESS_START: 'setup.cfg' | ||
|
|
||
| # - task: PublishTestResults@2 | ||
| # displayName: 'Publish Test Results **/test-results.xml' | ||
| # inputs: | ||
| # testResultsFiles: '**/test-results.xml' | ||
| # testRunTitle: 'AutoML' | ||
| # condition: succeededOrFailed() | ||
| # package: '.[automl]' |
There was a problem hiding this comment.
Had to disable AutoML tests, because it seems like they were already broken by something changing server-side for AutoML and I couldn't figure out the necessary changes after a small amount of debugging. I've opened a new issue (#270) to fix this.
kbattocchi
commented
Aug 11, 2020
| lightning package implements such a class: | ||
|
|
||
| .. testcode:: | ||
| lightning package implements such a class:: |
There was a problem hiding this comment.
Released versions of lightning are currently not compatible with sklearn 0.23 (though this problem has been fixed in the lightning GitHub repo - see scikit-learn-contrib/lightning#142). We can revert this small change if there is a new PyPI release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.