Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain column names from input dataframes/series #337

Merged
merged 6 commits into from
Dec 16, 2020

Conversation

moprescu
Copy link
Contributor

@moprescu moprescu commented Dec 9, 2020

Functions like cate_feature_names, summary, population_summary
display the input column names if inputs are pandas DataFrames or
Series.
In this commit:

  • changed cate_estimator, ortho_learner and inference classes to set
    input names upon fit
  • moved input verification to the base class for some estimators
  • modified customer scenario notebooks to reflect changes
  • added tests

Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments; approved subject to their resolution

econml/cate_estimator.py Outdated Show resolved Hide resolved
econml/inference.py Outdated Show resolved Hide resolved
econml/inference.py Outdated Show resolved Hide resolved
econml/inference.py Outdated Show resolved Hide resolved
econml/inference.py Show resolved Hide resolved
econml/utilities.py Show resolved Hide resolved
econml/cate_estimator.py Outdated Show resolved Hide resolved
@moprescu moprescu force-pushed the moprescu/column_names branch 2 times, most recently from b31b836 to d821ebb Compare December 15, 2020 21:40
Miruna Oprescu and others added 6 commits December 15, 2020 20:40
Functions like `cate_feature_names`, `summary`, `population_summary`
display the input column names if inputs are pandas DataFrames or
Series.
In this commit:
* changed cate_estimator, ortho_learner and inference classes to set
  input names upon fit
* moved input verification to the base class for some estimators
* modified customer scenario notebooks to reflect changes
* added tests
Co-authored-by: Keith Battocchi <[email protected]>
Co-authored-by: Keith Battocchi <[email protected]>
@moprescu moprescu merged commit e55b093 into master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants