Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few 0.9.0 bugs #422

Merged
merged 4 commits into from
Mar 3, 2021
Merged

Fix a few 0.9.0 bugs #422

merged 4 commits into from
Mar 3, 2021

Conversation

moprescu
Copy link
Contributor

@moprescu moprescu commented Feb 25, 2021 •
edited by kbattocchi
Loading

heimengqi
heimengqi approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@heimengqi heimengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

econml/utilities.py Outdated Show resolved Hide resolved
kbattocchi
kbattocchi approved these changes Feb 27, 2021
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I added one suggestion but nothing major.

econml/utilities.py Outdated Show resolved Hide resolved
@heimengqi
Copy link
Contributor

#419 (comment)
This comment should be addressed in your PR.

@moprescu moprescu merged commit 2cc9f62 into master Mar 3, 2021
@moprescu moprescu deleted the moprescu/bugfix branch March 3, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbattocchi kbattocchi kbattocchi approved these changes

@heimengqi heimengqi heimengqi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature name checks should be more robust
3 participants
@moprescu @heimengqi @kbattocchi