-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added python 3.11 to github actions and pyproject #964
Conversation
The error says, "Unable to find installation candidates for pytorch for 3.11". But the pyproject version specification is >=1.2.1, not sure why it is unable to pick up torch 2.0.1 which does support 3.11. |
Does torch 2.0.1 have any dependencies that are incompatible with our other version requirements? |
Their requirements are quite simple without any version requirements: https://github.com/pytorch/pytorch/blob/main/pyproject.toml |
The dependency conflict is resolved now. But there is an error in GCM. @bloebp can you take a look?
|
Seems the random seed type changed in 3.11. Will take a look. |
Signed-off-by: Patrick Bloebaum <[email protected]>
…low custom index-url
Okay, fixed the torch dependency. Needed to specify a separate index_url for torch, which needs poetry >=1.5. So updated the poetry version too. The only problem: the docker image for the docs build also needs to be updated with the new poetry version. Not sure how to do that. Line 9 in a1c6c04
|
Signed-off-by: Patrick Bloebaum <[email protected]>
Seems the docker container is working now. We really only needed to change the version in the line you referenced :) |
wonderful, thanks @bloebp. Can you approve this PR so that I can merge it? |
After #963, DoWhy supports python 3.11. Added 3.11 to CI tests and pyproject description for pypi.