Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added python 3.11 to github actions and pyproject #964

Merged
merged 9 commits into from
Jul 16, 2023

Conversation

amit-sharma
Copy link
Member

After #963, DoWhy supports python 3.11. Added 3.11 to CI tests and pyproject description for pypi.

@amit-sharma amit-sharma requested a review from bloebp June 27, 2023 01:32
@amit-sharma
Copy link
Member Author

The error says, "Unable to find installation candidates for pytorch for 3.11". But the pyproject version specification is >=1.2.1, not sure why it is unable to pick up torch 2.0.1 which does support 3.11.

@emrekiciman
Copy link
Member

Does torch 2.0.1 have any dependencies that are incompatible with our other version requirements?

@amit-sharma
Copy link
Member Author

Their requirements are quite simple without any version requirements: https://github.com/pytorch/pytorch/blob/main/pyproject.toml

@amit-sharma
Copy link
Member Author

The dependency conflict is resolved now. But there is an error in GCM. @bloebp can you take a look?

TypeError: The only supported seed types are: None,
int, float, str, bytes, and bytearray.

@bloebp
Copy link
Member

bloebp commented Jun 30, 2023

The dependency conflict is resolved now. But there is an error in GCM. @bloebp can you take a look?

TypeError: The only supported seed types are: None,
int, float, str, bytes, and bytearray.

Seems the random seed type changed in 3.11. Will take a look.

@amit-sharma
Copy link
Member Author

Okay, fixed the torch dependency. Needed to specify a separate index_url for torch, which needs poetry >=1.5. So updated the poetry version too.

The only problem: the docker image for the docs build also needs to be updated with the new poetry version. Not sure how to do that.

RUN curl -sSL https://install.python-poetry.org | python3 - --version 1.3.1
This line needs to be updated too

@bloebp
Copy link
Member

bloebp commented Jul 14, 2023

Seems the docker container is working now. We really only needed to change the version in the line you referenced :)

@amit-sharma
Copy link
Member Author

wonderful, thanks @bloebp. Can you approve this PR so that I can merge it?

@amit-sharma amit-sharma merged commit dcd995b into main Jul 16, 2023
30 of 31 checks passed
@amit-sharma amit-sharma deleted the update-ghactions-with-py311 branch July 16, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants