Fix: field alias for date_accepted field #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwasser
commented
Feb 28, 2024
lwasser
commented
Feb 28, 2024
lwasser
commented
Feb 28, 2024
| @@ -572,9 +579,6 @@ def get_issue_meta( | |||
| """ | |||
| issue_meta = {} | |||
| for item in body_data[0:end_range]: | |||
| # Clean date accepted element | |||
There was a problem hiding this comment.
this was just a thing i added in a really random place. it worked but it is so hard to find it if you're working on the code.
lwasser
commented
Feb 28, 2024
src/pyosmeta/parse_issues.py
Outdated
| @@ -161,7 +161,11 @@ class ReviewModel(BaseModel): | |||
| reviewer_2: dict[str, str | None] = {} | |||
| archive: Optional[str] = None | |||
| version_accepted: Optional[str] = None | |||
| date_accepted: Optional[str] = None | |||
| date_accepted: Optional[str] = Field( | |||
There was a problem hiding this comment.
here i added an alias to allow us to skip the step of cleaning up the field name
lwasser
commented
Feb 28, 2024
|
|
||
| # We could setup some example data using fixtures and a conf.py | ||
| # Once we have a better view of the test suite. | ||
| example = { |
There was a problem hiding this comment.
we may end up creating fixtures for some of these things that we can reuse. but for now i just added a variable object to the test so we have a test for aliases
|
oops failing. moving to draft |
Fix: more dtis
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 41.64% 44.00% +2.36%
==========================================
Files 4 4
Lines 461 459 -2
Branches 74 73 -1
==========================================
+ Hits 192 202 +10
+ Misses 268 253 -15
- Partials 1 4 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than fixing the entire thing i'm working towards cleaning up the parse_issues method. This is a small fix that
i'm guessing there are better ways to setup tests like this but it's a start and i'm trying to keep this contained. this addresses #91 in (a very small) part.