Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make parse comment more readable #115

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Feb 29, 2024

closes #91 to make the method easier to follow and more readable.
As it was there were multiple nested helpers making it super hard to follow / trouble shoot. i'm trying to surface each step and make each method name more user friendly with this draft pr.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 19.23077% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 43.72%. Comparing base (484102a) to head (9fc98f7).

❗ Current head 9fc98f7 differs from pull request most recent head 7a106a2. Consider uploading reports for the commit 7a106a2 to get more accurate results

Files Patch % Lines
src/pyosmeta/parse_issues.py 19.23% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   44.00%   43.72%   -0.29%     
==========================================
  Files           4        4              
  Lines         459      462       +3     
  Branches       73       73              
==========================================
  Hits          202      202              
- Misses        253      256       +3     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lwasser lwasser marked this pull request as ready for review March 6, 2024 23:53
@lwasser
Copy link
Member Author

lwasser commented Mar 7, 2024

ok i have added some very basic tests and some structure around the test suite. i don't want to bloat this pr even further so i think this is ready for a review / merge. ✨

@lwasser lwasser merged commit a2f4f64 into pyOpenSci:main Mar 7, 2024
2 checks passed
@lwasser lwasser deleted the refactor2 branch March 7, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor needed for parse_issue_header method
1 participant