Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions to resolve nodejs 16 warnings #128

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

willingc
Copy link
Collaborator

@willingc willingc commented Mar 8, 2024

Partially addresses #113

This PR makes the versions used by checkout and python actions the same across all files. This should remove the warnings seen on some workflows about NodeJS 16 deprecation.

@willingc willingc requested a review from lwasser March 8, 2024 19:49
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.56%. Comparing base (1d3396c) to head (eec0d9d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   47.56%   47.56%           
=======================================
  Files           7        7           
  Lines         473      473           
  Branches       74       74           
=======================================
  Hits          225      225           
  Misses        244      244           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willingc willingc added this to the March 2024 Release milestone Mar 8, 2024
Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@lwasser lwasser merged commit 5256f04 into pyOpenSci:main Mar 8, 2024
4 checks passed
@willingc willingc deleted the ci-nodejs branch March 9, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants