Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cli on pull requests #170

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Conversation

blink1073
Copy link
Collaborator

@blink1073 blink1073 commented Jul 1, 2024

Addresses #168

@blink1073 blink1073 marked this pull request as ready for review July 1, 2024 20:38
@lwasser
Copy link
Member

lwasser commented Jul 1, 2024

thank you!!

@@ -21,6 +21,17 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: hatch run test:run-report
- name: Run CLIs against website
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we run this as a cron job as well? i ask because often what happens is that there is an issue in how a user fills out an issue. so they do something wierd (text wise) and it breaks the build. i was thikning if we ran this every week or twice a week that would catch those issues before we go to update contributors (i think?) i'm not sure if that thought process makes sense or not...

but in this case i definitely broke something via a pr and this will fix that instance!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@blink1073 blink1073 requested a review from lwasser July 2, 2024 00:36
@lwasser
Copy link
Member

lwasser commented Jul 2, 2024

thank you @blink1073 !! i'm going to merge this and then create a new release. in the future you can just merge (if you want!) !!

@lwasser lwasser merged commit a5d07c5 into pyOpenSci:main Jul 2, 2024
2 checks passed
@blink1073 blink1073 deleted the test-update-contribs branch July 2, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants