THzTools submission #209

jsdodge · 2024-08-01T11:54:53Z

Submitting Author: Name (@jsdodge)
All current maintainers: (@jsdodge)
Package Name: THzTools
Data analysis software tools for terahertz time-domain spectroscopy (THz-TDS)
Repository Link: https://github.com/dodge-research-group/thztools
Version submitted: 0.5.4
EiC: @cmarmo
Editor:@banesullivan
Reviewer 1: @frank1010111
Reviewer 2: @Romain-Peretti
Archive: TBD
JOSS DOI: TBD
Version accepted: TBD
Date accepted (month/day/year): TBD

Code of Conduct & Commitment to Maintain Package

I agree to abide by pyOpenSci's Code of Conduct during the review process and in maintaining my package after should it be accepted.
I have read and will commit to package maintenance after the review as per the pyOpenSci Policies Guidelines.

Description

Include a brief paragraph describing what your package does:

THzTools provides tools to simplify and improve procedures for data analysis in terahertz time-domain spectroscopy (THz-TDS). Some of the methods included in the package were described previously in the paper at this link. As the name suggests, terahertz time-domain spectroscopy involves measurements of terahertz-frequency electromagnetic waveforms that are are acquired as a function of time. A variety of methods exist to transform these measurements into functions of frequency, but the standard procedures have several pitfalls. THzTools provides software tools that make it easier for researchers to use the best available methods for analyzing their data.

Scope

Please indicate which category or categories.
Check out our package scope page to learn more about our
scope. (If you are unsure of which category you fit, we suggest you make a pre-submission inquiry):
- Data retrieval
- Data extraction
- Data processing/munging
- Data deposition
- Data validation and testing
- Data visualization¹
- Workflow automation
- Citation management and bibliometrics
- Scientific software wrappers
- Database interoperability

Domain Specific

Geospatial
Education

Community Partnerships

If your package is associated with an
existing community please check below:

Astropy:My package adheres to Astropy community standards
Pangeo: My package adheres to the Pangeo standards listed in the pyOpenSci peer review guidebook

For all submissions, explain how and why the package falls under the categories you indicated above. In your explanation, please address the following points (briefly, 1-2 sentences for each):
- Who is the target audience and what are scientific applications of this package?
  The target audience is researchers working with THz-TDS, although the procedures may be useful in other areas that use time-domain measurement systems. The package is designed for characterizing the time-domain noise performance of THz-TDS measurement systems and for analyzing the results from these systems in the frequency domain.
- Are there other Python packages that accomplish the same thing? If so, how does yours differ?
  The Fit-TDS package provides a graphical user interface that simplifies THz-TDS data analysis with standard analysis methods. THzTools focuses on lower-level statistical procedures, and implements algorithms that are not available in Fit-TDS.
- If you made a pre-submission enquiry, please paste the link to the corresponding issue, forum post, or other discussion, or @tag the editor you contacted: @NickleDave

Technical checks

For details about the pyOpenSci packaging requirements, see our packaging guide. Confirm each of the following by checking the box. This package:

does not violate the Terms of Service of any service it interacts with.
uses an OSI approved license.
contains a README with instructions for installing the development version.
includes documentation with examples for all functions.
contains a tutorial with examples of its essential functions and uses.
has a test suite.
has continuous integration setup, such as GitHub Actions CircleCI, and/or others.

Publication Options

Do you wish to automatically submit to the Journal of Open Source Software? If so:

JOSS Checks

The package has an obvious research application according to JOSS's definition in their submission requirements. Be aware that completing the pyOpenSci review process does not guarantee acceptance to JOSS. Be sure to read their submission requirements (linked above) if you are interested in submitting to JOSS.
The package is not a "minor utility" as defined by JOSS's submission requirements: "Minor ‘utility’ packages, including ‘thin’ API clients, are not acceptable." pyOpenSci welcomes these packages under "Data Retrieval", but JOSS has slightly different criteria.
The package contains a paper.md matching JOSS's requirements with a high-level description in the package root or in inst/.
The package is deposited in a long-term repository with the DOI: https://zenodo.org/doi/10.5281/zenodo.10100093

Note: JOSS accepts our review as theirs. You will NOT need to go through another full review. JOSS will only review your paper.md file. Be sure to link to this pyOpenSci issue when a JOSS issue is opened for your package. Also be sure to tell the JOSS editor that this is a pyOpenSci reviewed package once you reach this step.

Are you OK with Reviewers Submitting Issues and/or pull requests to your Repo Directly?

This option will allow reviewers to open smaller issues that can then be linked to PR's rather than submitting a more dense text based review. It will also allow you to demonstrate addressing the issue via PR links.

Yes I am OK with reviewers submitting requested changes as issues to my repo. Reviewers will then link to the issues in their submitted review.

Confirm each of the following by checking the box.

I have read the author guide.
I expect to maintain this package for at least 2 years and can help find a replacement for the maintainer (team) if needed.

Please fill out our survey

Last but not least please fill out our pre-review survey. This helps us track
submission and improve our peer review process. We will also ask our reviewers
and editors to fill this out.

P.S. Have feedback/comments about our review process? Leave a comment here

Editor and Review Templates

The editor template can be found here.

The review template can be found here.

Please fill out a pre-submission inquiry before submitting a data visualization package. ↩

The text was updated successfully, but these errors were encountered:

cmarmo · 2024-08-13T08:00:27Z

Hello @jsdodge ! Thank you for submitting THzTools to pyOpenSci.
Sorry for the delay of my answer!
I'm Chiara and I'm going to take care of your submission for the initial editorial checks.
I will be back to you by the end of the week.
Thanks for your patience!

jsdodge · 2024-08-15T03:02:52Z

Hi Chiara,

Thanks for the update on the timeline. Do you have any suggestions for ways that we can continue development without disrupting the review? Would it be ok, for example, to continue developing on the dev branch as long as we don't merge these into the main branch?

cmarmo · 2024-08-15T09:51:26Z

Do you have any suggestions for ways that we can continue development without disrupting the review? Would it be ok, for example, to continue developing on the dev branch as long as we don't merge these into the main branch?

I'm starting the editorial checks right now: I can perform them on the main branch if you prefer, once we agree on a version to be submitted you can tag the last modifications and we can update the description of the issue. Would that be ok for you?

cmarmo · 2024-08-15T13:31:58Z

Editor in Chief checks

Hi @jsdodge ! Thank you again for submitting your package for pyOpenSci review.
Below are the basic checks that your package needs to pass to begin our review.
If some of these are missing, we will ask you to work on them before the review process begins.

Please check our Python packaging guide for more information on the elements
below.

Initial onboarding survey was filled out
We appreciate each maintainer of the package filling out this survey individually. 🙌
Thank you authors in advance for setting aside five to ten minutes to do this. It truly helps our organization. 🙌

Editor comments

THzTools is in excellent shape, congratulations!
I have some minor comments before starting looking for an editor:

in the README.md file installation and development instructions are missing: a simple pip install and/or conda install will be enough (this explicits the fact that the package is available from both the channels), and then links to installation and development pages in the documentation.
the CONTRIBUTING.md file is missing: do you mind adding it with some basic instructions and a link to the contribuuting section in the documentation?
I noticed that in the issue template for bug reports the explanation says "help us improve SciPy" ... 😁

Do you have any suggestions for ways that we can continue development without disrupting the review? Would it be ok, for example, to continue developing on the dev branch as long as we don't merge these into the main branch?

I'm starting the editorial checks right now: I can perform them on the main branch if you prefer, once we agree on a version to be submitted you can tag the last modifications and we can update the description of the issue. Would that be ok for you?

I realize my answer was a bit out of scope... sorry for that. Indeed, I believe it is a good idea to continue the development in a separate branch during review: however, reviewers might ask for modifications too and everything would in principle end in a new version accepted at the end of the review process. Please just clarify with reviewers in which branch you are addressing their comments, we had some misunderstanding in the past.

jsdodge · 2024-08-15T17:36:21Z

Hi Chiara,

Thanks! We can add installation instructions to the README.md file and change the issue template right away. This raises a similar question to my earlier one: should we do this in the main branch? Normally we would also bump the version number when making changes in main, but the submission version is listed as v0.5.0.

Regarding the CONTRIBUTING.md file, we have a contributing.rst file in /docs/source/. Could you recommend a way to include this information at the top level in a CONTRIBUTING.md file and in the documentation without duplicating it? A related question is whether we can do the same thing with the CODE_OF_CONDUCT.md file. Currently we just have a GitHub link to CODE_OF_CONDUCT.md in contributing.rst, but it would be better to include it directly in the documentation. We used a link because we didn't know how to use ReST to pull it into the documentation source.

cmarmo · 2024-08-15T19:07:16Z

Thanks! We can add installation instructions to the README.md file and change the issue template right away. This raises a similar question to my earlier one: should we do this in the main branch? Normally we would also bump the version number when making changes in main, but the submission version is listed as v0.5.0.

Technically the review is not started yet: once done with the changes we can edit the issue description.

Regarding the CONTRIBUTING.md file, we have a contributing.rst file in /docs/source/. Could you recommend a way to include this information at the top level in a CONTRIBUTING.md file and in the documentation without duplicating it?

Some general information would be enough in the CONTRIBUTING.md file: a link to contributing.rst there will complete the instructions. See for example what is done in one of the previously accepted packages.

A related question is whether we can do the same thing with the CODE_OF_CONDUCT.md file. Currently we just have a GitHub link to CODE_OF_CONDUCT.md in contributing.rst, but it would be better to include it directly in the documentation. We used a link because we didn't know how to use ReST to pull it into the documentation source.

Your solution is fine with our standards: if you prefer to have the code of conduct in the documentation then you can use the same approach suggested for the CONTRIBUTING.md file and link the documentation reference inside.

jsdodge · 2024-08-15T23:46:49Z

I just released THzTools v0.5.1 with the changes that you requested. I've also updated the version number in the submission documentation.

cmarmo · 2024-08-16T08:06:06Z

Thank you @jsdodge ! Time for me to look for an editor!

jsdodge · 2024-09-11T19:35:10Z

Hi @cmarmo, I have just updated the submission with the latest release, v0.5.2.

Could you please update me on the editor search?

cmarmo · 2024-09-12T06:33:24Z

Thank you @jsdodge for the follow-up

Could you please update me on the editor search?

I'm sorry to say that I am still looking... I guess the end of summer plus the beginning of the academic year are not making things easier.... thanks for your patience!

lwasser · 2024-10-07T19:55:57Z

@cmarmo thank you so much for leading the pre-checks for this package!! @jsdodge we just have had a rotation for our EiC (we do this every 3 months). To help us get caught up, I was able to find an editor from our team to take on this package! @banesullivan !! The next step here is to find reviewers. Do you have any reviewers in mind that we could reach out to? This area if quite specific and we'd like to have atleast one person with domain expertise, involved in the review. many thanks for your patience!

jsdodge · 2024-10-07T20:37:01Z

Thanks @lwasser ! And hello @banesullivan . We look forward to working with you on the review.

Would it be possible for us to contact potential reviewers privately before suggesting them to you? I'm hesitant to list people publicly here without consulting them first.

lwasser · 2024-10-07T21:33:39Z

@jsdodge of course. I think reaching out to them privately is ideal. Normally we allow one suggestion from the author(s) and then we will try to find a second. The second reviewer can be more generally focused on packaging/usability. Finding reviewers has taken some time lately.

jsdodge · 2024-10-08T20:49:35Z

Hi @lwasser and @banesullivan , Romain Peretti (ORCID) has kindly agreed to help with the review. He leads the @THzbiophotonics group at CNRS in Lille, France. Please let me know if you need further help with the review.

lwasser · 2024-10-08T21:46:28Z

@jsdodge this is great. I'll leave a few notes and then will let @banesullivan step in. We may have a second reviewer. In the meantime, does Romain have a GitHub handle so we can add them to this issue? The review will happen fully in this issue with links to any issues or pr's opened of course!

jsdodge · 2024-10-08T22:16:32Z

Thank you, @lwasser , I'm glad that you may have found a second reviewer. I believe that Romain's GitHub handle is @THzbiophotonics, but I'll check.

jsdodge · 2024-10-09T13:38:17Z

Hello, please use the GitHub handle @Romain-Peretti for Romain. Thanks!

banesullivan · 2024-10-10T05:13:57Z

👋 Hi @frank1010111 and @Romain-Peretti! Thank you for volunteering to review THzTools for pyOpenSci! I'm excited to kick off this review and I'll try to chime in with a few comments of my own but overall THzTools is looking in great shape -- wonderful work, @jsdodge!

Please fill out our pre-review survey

Before beginning your review, please fill out our pre-review survey. This helps us improve all aspects of our review and better understand our community. No personal data will be shared from this survey - it will only be used in an aggregated format by our Executive Director to improve our processes and programs.

@frank1010111 survey completed.
@Romain-Peretti survey completed.

The following resources will help you complete your review:

Here is the reviewers guide. This guide contains all of the steps and information needed to complete your review.
Here is the review template that you will need to fill out and submit
here as a comment, once your review is complete.

Please get in touch with any questions or concerns!

Your review is due: November ~8th, 2024

I've set the due date ~3 weeks out from now, but we're flexible here so please don't rush yourself if life or other things pop up and require you to delay a bit.

Reviewers: @frank1010111 @Romain-Peretti
Due date: 2024-11-08

frank1010111 · 2024-10-12T16:49:20Z

Package Review

Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide

As the reviewer I confirm that there are no conflicts of interest for me to review this work (If you are unsure whether you are in conflict, please speak to your editor before starting your review).

Documentation

The package includes all the following forms of documentation:

A statement of need clearly stating problems the software is designed to solve and its target audience in README.
Installation instructions: for the development version of the package and any non-standard dependencies in README.
Vignette(s) demonstrating major functionality that runs successfully locally.
Function Documentation: for all user-facing functions.
Examples for all user-facing functions.
Community guidelines including contribution guidelines in the README or CONTRIBUTING.
Metadata including author(s), author e-mail(s), a url, and any other relevant metadata e.g., in a pyproject.toml file or elsewhere.

Readme file requirements
The package meets the readme requirements below:

Package has a README.md file in the root directory.

The README should include, from top to bottom:

The package name
Badges for:
- Continuous integration and test coverage,
- Docs building (if you have a documentation website),
- A repostatus.org badge,
- Python versions supported,
- Current package version (on PyPI / Conda).

NOTE: If the README has many more badges, you might want to consider using a table for badges: see this example. Such a table should be more wide than high. (Note that the a badge for pyOpenSci peer-review will be provided upon acceptance.)

Short description of package goals.
Package installation instructions
Any additional setup required to use the package (authentication tokens, etc.)
Descriptive links to all vignettes. If the package is small, there may only be a need for one vignette which could be placed in the README.md file.
- Brief demonstration of package usage (as it makes sense - links to vignettes could also suffice here if package description is clear)
Link to your documentation website.
If applicable, how the package compares to other similar packages and/or how it relates to other packages in the scientific ecosystem.
Citation information

Usability

Reviewers are encouraged to submit suggestions (or pull requests) that will improve the usability of the package as a whole.
Package structure should follow general community best-practices. In general please consider whether:

Package documentation is clear and easy to find and use.
The need for the package is clear
All functions have documentation and associated examples for use
The package is easy to install

Functionality

For packages also submitting to JOSS

The package has an obvious research application according to JOSS's definition in their submission requirements.

Note: Be sure to check this carefully, as JOSS's submission requirements and scope differ from pyOpenSci's in terms of what types of packages are accepted.

The package contains a paper.md matching JOSS's requirements with:

A short summary describing the high-level functionality of the software
Authors: A list of authors with their affiliations
A statement of need clearly stating problems the software is designed to solve and its target audience.
References: With DOIs for all those that have one (e.g. papers, datasets, software).

Final approval (post-review)

The author has responded to my review and made changes to my satisfaction. I recommend approving this package.

Estimated hours spent reviewing: 4

Review Comments

jsdodge · 2024-10-12T20:15:18Z

Hi @frank1010111 , thanks for your feedback so far. How would you like to proceed with the code updates? I've already addressed the issues that you posted, but just in my local dev branch. At what point would you recommend that I push these changes to the remote, merge them with the main branch, and create a new release? Should I wait for you to complete your review before doing any or all of these?

frank1010111 · 2024-10-13T00:55:38Z

I appreciate it. If you want me to review the dev branch, I'm okay doing that. Whatever works best for you is good for me.

jsdodge · 2024-10-13T03:18:50Z

In that case, I merged the changes into the main branch and created a new release, THzTools v0.5.3 (beta). I also closed the issues that you raised. I see that there are several unchecked items, so I'll wait for further recommendations.

banesullivan · 2024-10-14T20:39:40Z

Hey @jsdodge, I anticipate that a few more changes will be made during this review process, so there is no need to issue a new release for each of these changes during the review (unless you prefer to do so!). As the review finalizes though, we can make sure a release is issued and update the version specifier in the submission.

Moving forward, would you please try to link back to this GitHub issue by pasting the URL link in the descriptions of any Pull Requests or new Issues? This will help us track changes to the software that were a direct result of this review and help us check off items in the reviewers comments. Thanks!

jsdodge · 2024-10-15T01:08:11Z

Thanks for the suggestions, @banesullivan , will do.

frank1010111 · 2024-10-16T01:48:10Z

Today, I checked the paper draft created by a github action and found it meets JOSS specifications.

frank1010111 · 2024-10-17T01:39:27Z

I've got to say, your documentation is beautifully organized.

jsdodge · 2024-10-17T01:59:08Z

Thank you! It's nice to have that effort recognized.

frank1010111 · 2024-10-18T00:58:04Z

A nit for your documentation is that you've got docstrings for the parameters of your dataclasses, but Sphinx expects docstrings for your attributes. For instance, the lines here in NoiseModel are rendered fine, but Sphinx doesn't know to put them with these attributes.

The solution to this oddity is something like this

@dataclass
class Snake:
    """Oh no, it's a snake!"""

    width: float
    """Width of the snake."""
    
    length: float
    """Length of the snake."""

Once again, it's a nit that you don't have to change. Your documentation is perfectly readable as is. Just a fun fact for you if you're as obsessive about these things as me.

jsdodge · 2024-10-18T06:07:32Z

Thanks for that suggestion. Just to clarify, I'm using the numpydoc extension, so are you recommending that I repeat the class Parameters section in a separate Attributes section, as in the ExampleError class listed in the Sphinx Example NumPy Style Python Docstrings?

frank1010111 · 2024-10-19T15:05:30Z

I did not know about that example. That's amazing

frank1010111 · 2024-10-19T15:22:06Z

I've run and played around with the example notebooks, and I'm overall very pleased with the package and documentation. Very nice work. After that last issue is closed, my review ought to be complete and I can recommend acceptance.

Romain-Peretti · 2024-10-19T16:11:58Z

Sorry I did not begin yet I ll try to do it from next Monday. Romain

On 19/10/2024 17:22, Frank Male wrote: I've run and played around with the example notebooks, and I'm overall very pleased with the package and documentation. Very nice work. After that last issue is closed, my review ought to be complete and I can recommend acceptance. — Reply to this email directly, view it on GitHub <#209 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BL6ZGXYHOADPEILNLRCTZ6TZ4J2LJAVCNFSM6AAAAABL2M3B32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTHE3DENJUGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Dr. Romain PERETTI (hab.) Leader of TeraHertz Biophotonics activity TeraHertz Photonics Group @ IEMN - CNRS (UMR 8520) Senior Member and Optics Express Associate editor @ OPTICA Phone: +33 32 019 78 76 ***@***.***

…

--------------UBLZWRgfADBXzwtyHFh92bjE Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> Sorry I did not begin yet I ll try to do it from next Monday. Romain <div class="moz-cite-prefix">On 19/10/2024 17:22, Frank Male wrote: </div> <blockquote type="cite" ***@***.***"> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> I've run and played around with the example notebooks, and I'm overall very pleased with the package and documentation. Very nice work. After that last issue is closed, my review ought to be complete and I can recommend acceptance. — Reply to this email directly, <a href="#209 (comment)" moz-do-not-send="true">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/BL6ZGXYHOADPEILNLRCTZ6TZ4J2LJAVCNFSM6AAAAABL2M3B32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTHE3DENJUGA" moz-do-not-send="true">unsubscribe</a>. You are receiving this because you were mentioned.<img src="https://github.com/notifications/beacon/BL6ZGX5BQ25CEOKXOVG24LLZ4J2LJA5CNFSM6AAAAABL2M3B32WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUQPK52Y.gif" alt="" moz-do-not-send="true" width="1" height="1">Message ID: <pyOpenSci/software-submission/issues/209/2423962540@github.com> <script type="application/ld+json">[ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#209 (comment)", "url": "#209 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script> </blockquote> <div class="moz-signature">-- <pre class="moz-signature">Dr. Romain PERETTI (hab.) Leader of TeraHertz Biophotonics activity TeraHertz Photonics Group @ IEMN - CNRS (UMR 8520) Senior Member and Optics Express Associate editor @ OPTICA Phone: +33 32 019 78 76 <a ***@***.***" ***@***.***</a> </pre> <img src="https://www.cnrs.fr/themes/custom/cnrs/logo.svg" name="Image1" style="padding-right: 55px" width="55" height="55" border="0" align="middle"> <img src="https://opticaorgdev.blob.core.windows.net/media/optica/media/osa.media/osa-logos/trianglebranding/senior_member_shadow.png" name="Image2" width="65" height="65" border="0" align="middle"> </div> </body> </html>

--------------UBLZWRgfADBXzwtyHFh92bjE--

jsdodge · 2024-10-19T20:00:55Z

Thanks for your help, @frank1010111 ! I've made the changes that you requested and created a new release, THzTools v0.5.4 (beta), in anticipation of your review approval. I appreciate your suggestions and your promptness in completing the review.

jsdodge · 2024-10-19T20:04:35Z

Thanks, @Romain-Peretti , I look forward to your feedback. As noted in the comment above, I have issued a new release in response to several helpful suggestions from @frank1010111 . I've updated the submission to indicate the updated release.

Romain-Peretti · 2024-10-23T15:21:56Z

So I feel very the same way as @frank1010111 it is very impressive and I bet useful for quite a lot of people (at least a great playground for my next students to understand a bit all of that).

I have a question about the way the Hessian are computed. We struggled during month to find a good way to calculate the hessian in one of our project and I am not sure to follow how it is done here. It looks like you are computing the Hessian by yourself or am I wrong ?

Romain

jsdodge · 2024-10-23T16:51:20Z

Thank you for your feedback! I'm glad you think the software will be useful.

To your question, for the noisefit function we use scipy.minimize with the BFGS method to do the optimization, which does not require the Hessian. We tried other methods that did require the Hessian, however, so we have an internal function, _hess_noisefit to compute it that we left in the main code, in case we find a way to use it later to improve the computational speed. We compute the Jacobian explicitly in _jac_noisefit.

For the fit function, we use scipy.least_squares to do the minimization (see here), which also just uses the Jacobian. Internally, we fit for mu in addition to the fit parameters of the frequency response function, so the Jacobian that we compute internally is different from the Jacobian with respect to the fit parameters supplied to fit. We compute that Jacobian here.

Romain-Peretti · 2024-11-05T09:50:45Z

Ok sorry for the silence ... I had a bit to do outside of the office. I finished the review process the only very small comment I would have and that is maybe a misunderstanding from my side is that the author list for JOSS is maybe the one of the Software Package but maybe adding it to the paper.md together with the affiliation would clarify it.

Package Review

Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide

As the reviewer I confirm that there are no conflicts of interest for me to review this work (If you are unsure whether you are in conflict, please speak to your editor before starting your review).

Documentation

The package includes all the following forms of documentation:

A statement of need clearly stating problems the software is designed to solve and its target audience in README.
Installation instructions: for the development version of the package and any non-standard dependencies in README.
Vignette(s) demonstrating major functionality that runs successfully locally.
Function Documentation: for all user-facing functions.
Examples for all user-facing functions.
Community guidelines including contribution guidelines in the README or CONTRIBUTING.
Metadata including author(s), author e-mail(s), a url, and any other relevant metadata e.g., in a pyproject.toml file or elsewhere.

Readme file requirements
The package meets the readme requirements below:

Package has a README.md file in the root directory.

The README should include, from top to bottom:

The package name
Badges for:
- Continuous integration and test coverage,
- Docs building (if you have a documentation website),
- A repostatus.org badge,
- Python versions supported,
- Current package version (on PyPI / Conda).

NOTE: If the README has many more badges, you might want to consider using a table for badges: see this example. Such a table should be more wide than high. (Note that the a badge for pyOpenSci peer-review will be provided upon acceptance.)

Short description of package goals.
Package installation instructions
Any additional setup required to use the package (authentication tokens, etc.)
Descriptive links to all vignettes. If the package is small, there may only be a need for one vignette which could be placed in the README.md file.
- Brief demonstration of package usage (as it makes sense - links to vignettes could also suffice here if package description is clear)
Link to your documentation website.
If applicable, how the package compares to other similar packages and/or how it relates to other packages in the scientific ecosystem.
Citation information

Usability

Reviewers are encouraged to submit suggestions (or pull requests) that will improve the usability of the package as a whole.
Package structure should follow general community best-practices. In general please consider whether:

Package documentation is clear and easy to find and use.
The need for the package is clear
All functions have documentation and associated examples for use
The package is easy to install

Functionality

For packages also submitting to JOSS

The package has an obvious research application according to JOSS's definition in their submission requirements.

Note: Be sure to check this carefully, as JOSS's submission requirements and scope differ from pyOpenSci's in terms of what types of packages are accepted.

The package contains a paper.md matching JOSS's requirements with:

A short summary desribing the high-level functionality of the software
Authors: A list of authors with their affiliations
A statement of need clearly stating problems the software is designed to solve and its target audience.
References: With DOIs for all those that have one (e.g. papers, datasets, software).

Final approval (post-review)

The author has responded to my review and made changes to my satisfaction. I recommend approving this package.

Estimated hours spent reviewing: 5

jsdodge · 2024-11-05T16:34:25Z

Thanks @Romain-Peretti ! I'd like to clarify your comment: the author list for the paper (linked here) is the same as the authors listed in the pyproject.toml metadata (linked here). Are you recommending that we change that?

Romain-Peretti · 2024-11-05T16:52:54Z

Hum not at all, I simply missed it .. Sorry about that Romain

On 05/11/2024 17:34, J. Steven Dodge wrote: Thanks @Romain-Peretti <https://github.com/Romain-Peretti> ! I'd like to clarify your comment: the author list for the paper (linked here <https://github.com/dodge-research-group/thztools/blob/92d074f85dfe093e11225c92770c382259643834/paper/paper.md?plain=1#L12C1-L38C19>) is the same as the authors listed in the |pyproject.toml| <https://github.com/dodge-research-group/thztools/blob/92d074f85dfe093e11225c92770c382259643834/pyproject.toml#L15C1-L24C1> metadata (linked here <https://github.com/dodge-research-group/thztools/blob/92d074f85dfe093e11225c92770c382259643834/pyproject.toml#L15C1-L24C1>). Are you recommending that we change that? — Reply to this email directly, view it on GitHub <#209 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BL6ZGX2QMJRUH6BQHHYTNCDZ7DXSRAVCNFSM6AAAAABL2M3B32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJXGY2TEOJZGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Dr. Romain PERETTI (hab.) Leader of TeraHertz Biophotonics activity TeraHertz Photonics Group @ IEMN - CNRS (UMR 8520) Senior Member and Optics Express Associate editor @ OPTICA Phone: +33 32 019 78 76 ***@***.***

…

--------------leOlVCjdudh7miLwqXGGC4y0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> Hum not at all, I simply missed it .. Sorry about that Romain <div class="moz-cite-prefix">On 05/11/2024 17:34, J. Steven Dodge wrote: </div> <blockquote type="cite" ***@***.***"> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/Romain-Peretti/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/Romain-Peretti" ***@***.***</a> ! I'd like to clarify your comment: the author list for the paper (linked <a href="https://github.com/dodge-research-group/thztools/blob/92d074f85dfe093e11225c92770c382259643834/paper/paper.md?plain=1#L12C1-L38C19" moz-do-not-send="true">here</a>) is the same as the authors listed in the <a href="https://github.com/dodge-research-group/thztools/blob/92d074f85dfe093e11225c92770c382259643834/pyproject.toml#L15C1-L24C1" moz-do-not-send="true"><code class="notranslate">pyproject.toml</code></a> metadata (linked <a href="https://github.com/dodge-research-group/thztools/blob/92d074f85dfe093e11225c92770c382259643834/pyproject.toml#L15C1-L24C1" moz-do-not-send="true">here</a>). Are you recommending that we change that? — Reply to this email directly, <a href="#209 (comment)" moz-do-not-send="true">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/BL6ZGX2QMJRUH6BQHHYTNCDZ7DXSRAVCNFSM6AAAAABL2M3B32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJXGY2TEOJZGA" moz-do-not-send="true">unsubscribe</a>. You are receiving this because you were mentioned.<img src="https://github.com/notifications/beacon/BL6ZGX4MYK7GY3I733G27DTZ7DXSRA5CNFSM6AAAAABL2M3B32WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUSPTHP4.gif" alt="" moz-do-not-send="true" width="1" height="1">Message ID: <pyOpenSci/software-submission/issues/209/2457652990@github.com> </blockquote> <div class="moz-signature">-- <pre class="moz-signature">Dr. Romain PERETTI (hab.) Leader of TeraHertz Biophotonics activity TeraHertz Photonics Group @ IEMN - CNRS (UMR 8520) Senior Member and Optics Express Associate editor @ OPTICA Phone: +33 32 019 78 76 <a ***@***.***" ***@***.***</a> </pre> <img src="https://www.cnrs.fr/themes/custom/cnrs/logo.svg" name="Image1" style="padding-right: 55px" width="55" height="55" border="0" align="middle"> <img src="https://opticaorgdev.blob.core.windows.net/media/optica/media/osa.media/osa-logos/trianglebranding/senior_member_shadow.png" name="Image2" width="65" height="65" border="0" align="middle"> </div> </body> </html>

--------------leOlVCjdudh7miLwqXGGC4y0--

jsdodge · 2024-11-05T17:37:09Z

No problem, thanks again @Romain-Peretti !

jsdodge · 2024-11-05T17:39:11Z

Hi @banesullivan , now that both reviewers have indicated their approval, what's next?

banesullivan · 2024-11-09T00:01:53Z

Hi @jsdodge, apologies for my delay, been on vacation for a bit. I will double check everything above and then I'll update on next steps this weekend! Thanks for your patience!

jsdodge added 0/pre-review-checks New Submission! labels Aug 1, 2024

github-project-automation bot added this to peer-review-status Aug 1, 2024

lwasser moved this to pre-review-checks in peer-review-status Aug 1, 2024

cmarmo self-assigned this Aug 15, 2024

cmarmo added 0/seeking-editor and removed 0/pre-review-checks New Submission! labels Aug 16, 2024

lwasser moved this from pre-review-checks to seeking-editor in peer-review-status Aug 16, 2024

lwasser assigned banesullivan Oct 7, 2024

lwasser added 2/seeking-reviewers and removed 0/seeking-editor labels Oct 7, 2024

lwasser unassigned cmarmo Oct 7, 2024

lwasser moved this from pre-review-checks to under-review in peer-review-status Oct 9, 2024

frank1010111 mentioned this issue Oct 12, 2024

DOC: add repostatus badge dodge-research-group/thztools#58

Closed

frank1010111 mentioned this issue Oct 17, 2024

DOC: README requirements for PyOpenSci dodge-research-group/thztools#61

Closed

4 tasks

jsdodge mentioned this issue Oct 17, 2024

Dev dodge-research-group/thztools#62

Merged

4 tasks

frank1010111 mentioned this issue Oct 19, 2024

DOC: Extra docstrings dodge-research-group/thztools#63

Closed

2 tasks

THzTools submission #209

THzTools submission #209

Comments

jsdodge commented Aug 1, 2024 • edited Loading

Code of Conduct & Commitment to Maintain Package

Description

Scope

Domain Specific

Community Partnerships

Technical checks

Publication Options

Are you OK with Reviewers Submitting Issues and/or pull requests to your Repo Directly?

Please fill out our survey

Editor and Review Templates

Footnotes

cmarmo commented Aug 13, 2024

jsdodge commented Aug 15, 2024

cmarmo commented Aug 15, 2024

cmarmo commented Aug 15, 2024

Editor in Chief checks

Editor comments

jsdodge commented Aug 15, 2024

cmarmo commented Aug 15, 2024

jsdodge commented Aug 15, 2024

cmarmo commented Aug 16, 2024

jsdodge commented Sep 11, 2024

cmarmo commented Sep 12, 2024

lwasser commented Oct 7, 2024

jsdodge commented Oct 7, 2024

lwasser commented Oct 7, 2024

jsdodge commented Oct 8, 2024

lwasser commented Oct 8, 2024

jsdodge commented Oct 8, 2024

jsdodge commented Oct 9, 2024

banesullivan commented Oct 10, 2024 • edited Loading

Please fill out our pre-review survey

Your review is due: November ~8th, 2024

frank1010111 commented Oct 12, 2024 • edited Loading

Package Review

Documentation

Usability

Functionality

For packages also submitting to JOSS

Final approval (post-review)

Review Comments

jsdodge commented Oct 12, 2024

frank1010111 commented Oct 13, 2024

jsdodge commented Oct 13, 2024

banesullivan commented Oct 14, 2024

jsdodge commented Oct 15, 2024

frank1010111 commented Oct 16, 2024

frank1010111 commented Oct 17, 2024

jsdodge commented Oct 17, 2024

frank1010111 commented Oct 18, 2024

jsdodge commented Oct 18, 2024

frank1010111 commented Oct 19, 2024

frank1010111 commented Oct 19, 2024

Romain-Peretti commented Oct 19, 2024 via email

jsdodge commented Oct 19, 2024

jsdodge commented Oct 19, 2024

Romain-Peretti commented Oct 23, 2024

jsdodge commented Oct 23, 2024 • edited Loading

Romain-Peretti commented Nov 5, 2024 • edited Loading

Package Review

Documentation

Usability

Functionality

For packages also submitting to JOSS

Final approval (post-review)

jsdodge commented Nov 5, 2024

Romain-Peretti commented Nov 5, 2024 via email

jsdodge commented Nov 5, 2024

jsdodge commented Nov 5, 2024

banesullivan commented Nov 9, 2024

jsdodge commented Aug 1, 2024 •

edited

Loading

banesullivan commented Oct 10, 2024 •

edited

Loading

frank1010111 commented Oct 12, 2024 •

edited

Loading

jsdodge commented Oct 23, 2024 •

edited

Loading

Romain-Peretti commented Nov 5, 2024 •

edited

Loading