-
-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Huggingface Hub version #1098
Conversation
This is also important to resolve a version conflict with I doesn't seem that your commit is enough to resolve the issue, I just got an error: !pip install git+https://github.com/pyannote/pyannote-audio.git@refs/pull/1098/merge from pyannote.audio import Pipeline ValueError Traceback (most recent call last) in 1 frames /usr/local/lib/python3.7/dist-packages/pyannote/audio/core/pipeline.py in from_pretrained(cls, checkpoint_path, hparams_file, use_auth_token, cache_dir) /usr/local/lib/python3.7/dist-packages/pyannote/pipeline/pipeline.py in instantiate(self, params) ValueError: parameter 'segmentation_onset' does not exist |
Codecov ReportBase: 30.20% // Head: 30.20% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1098 +/- ##
========================================
Coverage 30.20% 30.20%
========================================
Files 61 61
Lines 3751 3751
========================================
Hits 1133 1133
Misses 2618 2618 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Is there something blocking the macos build? This may be related to an issue downstream in openai/whisper: openai/whisper#264 |
Will be part of next release. No ETA, though. |
I created a fork on the 2.0.1 release, which patches the huggingface_hub version: https://github.com/philschmid/pyannote-audio/tree/hub0.10 you can install it with |
Thanks @philschmid! I can confirm that this solves the entire issue. One addendum from my side:
environment creation (Make):
|
Thank you for the clean solution @lukas681 |
What does this PR do?
This PR updates the
huggingface_hub
package to avoid conflicts with libraries that use>0.9