Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setModelMenuBar accepts instance of MenusRegistry #139

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tlambert03
Copy link
Member

This makes it possible to run setModelMenuBar(app.menus) to quick generate a menu bar with all menus in an application

@tlambert03 tlambert03 added the enhancement New feature or request label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (0140de7) 100.00% compared to head (0488804) 99.55%.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #139      +/-   ##
===========================================
- Coverage   100.00%   99.55%   -0.45%     
===========================================
  Files           31       31              
  Lines         1783     1796      +13     
===========================================
+ Hits          1783     1788       +5     
- Misses           0        8       +8     
Files Coverage Δ
src/app_model/backends/qt/_qmainwindow.py 100.00% <100.00%> (ø)
src/app_model/backends/qt/_qmenu.py 93.49% <42.85%> (-6.51%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03
Copy link
Member Author

need to consider this:
if you run this on the test app, you get menus: ['File', 'Edit', 'File/Open_From', 'Help']
the File/Open_From is a submenu... so it reveals that we can't just make the menu bar from all menus... we need a way for the user to be involved. And with that being the case, this becomes a bit less useful, and perhaps should stay as a draft until that issue is considered

@tlambert03 tlambert03 marked this pull request as draft November 1, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

1 participant