-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace QSpinBox with QLargeIntSpinBox #572
Conversation
The range of QSpinBox is limited to a 32-bit signed integer - Python integers can go much larger than that. By using QLargeIntSpinBox instead, we can go much larger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM assuming everything passes
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
=======================================
Coverage 89.05% 89.05%
=======================================
Files 38 38
Lines 4466 4466
=======================================
Hits 3977 3977
Misses 489 489
☔ View full report in Codecov by Sentry. |
ok, this is pretty much ready to go. The failing napari/stardist/partseg tests are all because napari installs are failing at the moment, and unrelated to magicgui. The ubuntu-latest (3.9) pyqt5 is a legitimate superqt issue, but since it only appears to (repeatedly) happen on the specific combination of ubuntu/pyqt5/python3.9, it's a bit hard to test and fix. might just skip it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @gselzer!
The range of QSpinBox is limited to a 32-bit signed integer - Python integers can go much larger than that. By using QLargeIntSpinBox instead, we enable larger range options!