Change type_caster<PyObject>::name to object, as suggested by @Sk…

…ylion007
pybind · Apr 27, 2023 · 5ccb893 · 5ccb893
1 parent 9907943
commit 5ccb893
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/include/pybind11/type_caster_pyobject_ptr.h b/include/pybind11/type_caster_pyobject_ptr.h
@@ -13,7 +13,7 @@ PYBIND11_NAMESPACE_BEGIN(detail)
 template <>
 class type_caster<PyObject> {
 public:
-    static constexpr auto name = const_name("PyObject *");
+    static constexpr auto name = const_name("object"); // See discussion under PR #4601.
 
     // This overload is purely to guard against accidents.
     template <typename T,

diff --git a/tests/test_type_caster_pyobject_ptr.cpp b/tests/test_type_caster_pyobject_ptr.cpp
@@ -98,6 +98,8 @@ TEST_SUBMODULE(type_caster_pyobject_ptr, m) {
         return i;
     });
 
+    m.def("pass_pyobject_ptr_and_int", [](PyObject *, int) {});
+
 #ifdef PYBIND11_NO_COMPILE_SECTION // Change to ifndef for manual testing.
     {
         PyObject *ptr = nullptr;

diff --git a/tests/test_type_caster_pyobject_ptr.py b/tests/test_type_caster_pyobject_ptr.py
@@ -89,3 +89,8 @@ def test_return_list_pyobject_ptr_reference():
     # Insert `while True:` as the first line of this function and monitor the
     # process RES (Resident Memory Size) with the Unix top command.
     assert m.dec_ref_each_pyobject_ptr(vec_obj) == 2
+
+
+def test_type_caster_name_via_incompatible_function_arguments_type_error():
+    with pytest.raises(TypeError, match=r"1\. \(arg0: object, arg1: int\) -> None"):
+        m.pass_pyobject_ptr_and_int(ValueHolder(101), ValueHolder(202))