Skip to content

Commit

Permalink
Add warn disable for GGC 12 bound checking error (#5355)
Browse files Browse the repository at this point in the history
Issue: #5224

The `internals.registered_types_py...` line in pybind11.h triggers a
false-positive bounds checking warning in GCC 12.

This is discussed in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115824.

The workaround implemented is taken from suggestions then refactored to
use the `PYBIND11_WARNING_PUSH` and `PYBIND11_WARNING_POP` MACROS.
  • Loading branch information
BobbyRBruce authored Sep 15, 2024
1 parent 0cf3a0f commit a7910be
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions include/pybind11/pybind11.h
Original file line number Diff line number Diff line change
Expand Up @@ -1382,7 +1382,17 @@ class generic_type : public object {
} else {
internals.registered_types_cpp[tindex] = tinfo;
}

PYBIND11_WARNING_PUSH
#if defined(__GNUC__) && __GNUC__ == 12
// When using GCC 12 these warnings are disabled as they trigger
// false positive warnings. Discussed here:
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115824.
PYBIND11_WARNING_DISABLE_GCC("-Warray-bounds")
PYBIND11_WARNING_DISABLE_GCC("-Wstringop-overread")
#endif
internals.registered_types_py[(PyTypeObject *) m_ptr] = {tinfo};
PYBIND11_WARNING_POP
});

if (rec.bases.size() > 1 || rec.multiple_inheritance) {
Expand Down

0 comments on commit a7910be

Please sign in to comment.