Skip to content

Commit

Permalink
Remove explicit get_internals() from TEST_CASE("Threads") and `RE…
Browse files Browse the repository at this point in the history
…QUIRE(has_pybind11_internals_static());` along with it, based on #4218 (comment)
  • Loading branch information
Ralf W. Grosse-Kunstleve committed Oct 6, 2022
1 parent f12f194 commit ad126f5
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions tests/test_embed/test_interpreter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -292,11 +292,6 @@ TEST_CASE("Threads") {
auto locals = py::dict("count"_a = 0);

{
// This used to be triggered by py::gil_scoped_release().
// TODO: Explain why/how this is relevant to this unit test.
py::detail::get_internals();
REQUIRE(has_pybind11_internals_static());

py::gil_scoped_release gil_release{};

auto threads = std::vector<std::thread>();
Expand Down

0 comments on commit ad126f5

Please sign in to comment.