Fix how thread states are created (#1276) #1280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having pybind11 keep its own internal thread state can lead to an inconsistent situation where the Python interpreter has a thread state but pybind does not, and then when gil_scoped_acquire is called, pybind creates a new thread state instead of using the one created by the Python interpreter. This change gets rid of pybind's internal thread state and always uses the one created by the Python interpreter.
KyleFromKitware
force-pushed
the
thread_fix
branch
from
d033b8b
to
5b8ef2c
Compare
|
Closed because it has been superseded by #1286. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having pybind11 keep its own internal thread state can lead to an
inconsistent situation where the Python interpreter has a thread
state but pybind does not, and then when gil_scoped_acquire is
called, pybind creates a new thread state instead of using the one
created by the Python interpreter. This change gets rid of pybind's
internal thread state and always uses the one created by the Python
interpreter.