[READY] Implement an enum_ property "name" #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
reviewed
Apr 5, 2018
include/pybind11/pybind11.h
Outdated
| def_property_readonly("name", [m_entries_ptr](Type value) -> pybind11::str { | ||
| for (const auto &kv : reinterpret_borrow<dict>(m_entries_ptr)) { | ||
| if (pybind11::cast<Type>(kv.second[int_(0)]) == value) | ||
| return pybind11::str("{}").format(kv.first); |
There was a problem hiding this comment.
Going through format here is unnecessary: this can just be: return pybind11::str(kv.first);
|
I have added the documentation and addressed the review comment. |
jagerman
reviewed
Apr 6, 2018
docs/classes.rst
Outdated
|
|
||
| .. note:: | ||
|
|
||
| It is also possible to use ``py::str(enum)``, however these accomplish different |
There was a problem hiding this comment.
Typo: that should just be str(enum) (i.e. no py::), since this is a Python reference.
|
One minor doc fix, but then it looks good to me. One other comment to add in support of this PR: Python 3 (or older Pythons with |
The property returns the enum_ value as a string. For example: >>> import module >>> module.enum.VALUE enum.VALUE >>> str(module.enum.VALUE) 'enum.VALUE' >>> module.enum.VALUE.name 'VALUE' This is actually the equivalent of Boost.Python "name" property.
|
The |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property returns the enum_ value as a string.
For example:
This is actually the equivalent of Boost.Python "name" property.
@jagerman Pointed out #1122 as it is somewhat related. The reason I didn't propose this change there is because I believe that smaller changes are easier to both reason about and review.