-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Test PyPy 3.6 on travis #1720
Conversation
Adapted from pybind#1494
It seems PyPy lacks an implementation for |
There are only two errors here:
The first one truly doesn't exist in pypy. The second one exists as Because of the first error, how about detecting if we're compiling for PYPY and then doing something like: template <eval_mode mode = eval_statements>
object eval_file(str fname, object global = globals(), object local = object()) {
#ifndef pypy_macro
// current implementation
#else
#error PyPy doesn't support eval_file(), use eval() instead
#endif
} An alternative is reading the file into a string in |
Hi -- any news here? It would be cool to support recent versions of PyPy in the CI. |
Hi Konstantin, there was a recent upgrade to use PyPy 7.3 on travis, e.g. here is a random recent result (bottom of page): https://travis-ci.org/github/pybind/pybind11/builds/698654908 |
@rwgk great, thank you! No it's not relevant any more, any newer PyPy works |
Adapted from #1494 (it would enable pypy support for pytorch).