Adding fix for copy warning on clang 7 / macOS 10.14.4 #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's actually a neat warning! Can you rebase this onto the latest master just to have CI run on it? |
|
It’s really handy! I found a bug in my code with this warning (wrong return type). However, the CI runs on a recent clang and errors on warnings, so the fix is already in as part of the CI fix #1744. |
|
We need to try GCC 9 (still in beta, though) - it has a ton of new warnings and reporting features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This occurs if you have a high level of warnings set. See https://reviews.llvm.org/D43322?id=134514.