testing smart_holder as default #2872

See also: pybind#2583 Does not build with upstream master or pybind#2047, but builds with https://github.com/RobotLocomotion/pybind11 and almost runs: ``` Running tests in directory "/usr/local/google/home/rwgk/forked/EricCousineau-TRI/pybind11/tests": ================================================================================= test session starts ================================================================================= platform linux -- Python 3.8.5, pytest-5.4.3, py-1.9.0, pluggy-0.13.1 rootdir: /usr/local/google/home/rwgk/forked/EricCousineau-TRI/pybind11/tests, inifile: pytest.ini collected 2 items test_unique_ptr_member.py .F [100%] ====================================================================================== FAILURES ======================================================================================= _____________________________________________________________________________ test_pointee_and_ptr_owner ______________________________________________________________________________ def test_pointee_and_ptr_owner(): obj = m.pointee() assert obj.get_int() == 213 m.ptr_owner(obj) with pytest.raises(ValueError) as exc_info: > obj.get_int() E Failed: DID NOT RAISE <class 'ValueError'> test_unique_ptr_member.py:17: Failed ============================================================================= 1 failed, 1 passed in 0.06s ============================================================================= ```

…pecialization to make the bindings involving unique_ptr passing compile, but load and cast implementations are missing

…STACK (pointee)

https://github.com/rwgk/pybind11/tree/xxx_value_ptr_xxx_holder Systematically exercising returning and passing unique_ptr<T>, shared_ptr<T> with unique_ptr, shared_ptr holder. Observations: test_holder_unique_ptr: make_unique_pointee OK pass_unique_pointee BUILD_FAIL (as documented) make_shared_pointee Abort free(): double free detected pass_shared_pointee RuntimeError: Unable to load a custom holder type from a default-holder instance test_holder_shared_ptr: make_unique_pointee Segmentation fault (pybind#1138) pass_unique_pointee BUILD_FAIL (as documented) make_shared_pointee OK pass_shared_pointee OK

https://github.com/rwgk/pybind11/tree/xxx_value_ptr_xxx_holder Systematically exercising casting between shared_ptr<base>, shared_ptr<derived>.

Based on https://godbolt.org/z/4fdjaW by jorgbrown@ (thanks Jorg!).

…ptr holder.

(This demo does NOT involve smart pointers at all, unlike the otherwise similar test_smart_ptr_private_first_base.)

…hat this can be wrapped with Boost.Python, using boost::noncopyable)

…ybind#1333

…test).

98f1bbb).

…sh_wip from test_type_caster_bare_interface_demo.

…const.

… it cast_op operators.

…const]>>::load, and using it cast_op operators.

…f` directives.

…n, the values are not actually used yet).

…m type_caster_base (marked with comments).

…m type_caster_base (marked with comments). rtrn_mref and rtrn_mptr work via const_cast (to add const).

…m type_caster_base (marked with comments). rtrn_rref raises a RuntimeError, to be investigated.

…ration for handling smart pointers).

…st).

See new bullet point in comment section near the top. The variable was also renamed to reflect its function more accurately.

…ic, ASAN, MSAN, UBSAN clean.

…ng-format. Open question, with respect to the original code: https://github.com/pybind/pybind11/blob/76a160070b369f8d82b945c97924227e8b835c94/include/pybind11/pybind11.h#L1510 To me it looks like the exact situation marked as `std::shared_ptr<Good> gp1 = not_so_good.getptr();` here: https://en.cppreference.com/w/cpp/memory/enable_shared_from_this The comment there is: `// undefined behavior (until C++17) and std::bad_weak_ptr thrown (since C++17)` Does the existing code have UB pre C++17? I'll leave handling of enable_shared_from_this for later, as the need arises.

…lso renaming one cast to cast_const_raw_ptr, for clarity.

…ate code.

… a new Python instance.

…tialized/disowned in error message).

…g previous version of cast.h. This is currently the most practical approach. See PR pybind#2798 for background.

… baseline for generalizing the code.

…dded).

…s test_class_wip. test_classh_inheritance is still failing, but with a different error: [RuntimeError: Incompatible type (as_raw_ptr_unowned).]

…ocal to capture loaded_v_h, but untested and guarded with pybind11_failure("Untested"). This was done mainly to determine general feasibility. Note the TODO in pybind11.h, where type_caster_generic::local_load is currently hard-coded. test_classh_wip and test_classh_inheritance still pass, as before.

…local feature. Adding missing #includes.

…o the systematic approach used in test_class_wip. NO functional changes.

…on when convoluting with inheritance. NO functional changes.

… changes.

…cheme. NO functional changes.

… bypassing smart_holder shared_ptr tracking completely, but the tests pass and are sanitizer clean.

…_holder_type_caster_load cleanup.

…g local_load_safety_guard.

…N, MSAN, UBSAN clean.

…ntical to current master again, pybind11.h only has the generic_type::initialize(..., &type_caster_generic::local_load) change.

…ests rwgk/rwgk_tbx@a2c2f88 These tests are from experimenting, and for demonstrating UB in pybind11 multiple inheritance handling ("first_base"), to be fixed later.

…pletely.

…er_type_casters.h. The user-facing macro is now PYBIND11_SMART_HOLDER_TYPE_CASTERS.

…e_interface.

… with a trick.

…ed out with PR pybind#2822.

… NO functional changes. Preparation for follow-up work (to keep that diff smaller).

…U, py::smart_holder>.

…holder_type_caster<T>. Moving get_local_load_function_ptr, init_instance_for_type to smart_holder_type_caster_class_hooks. Expanding static_assert in py::type::handle_of<> to accommodate smart_holder_type_casters.

…_caster_generic, type_caster<T>. There are use cases in the wild that define both a custom type_caster and class_.

…rate PR pybind#2834.

…ry_value_reference.

…SEVERE CODE DUPLICATION. This commit is to establish a baseline for consolidating the unique_ptr code.

…er_poc.h. Leads to more fitting error messages. Enables use of unique_ptr<T, D> smart_holder_type_casters also for unique_ptr<T>.

…ndefined; there are many errors with the macro defined).

…rate PR pybind#2834.

…_AS_DEFAULT. With this test_class.cpp builds and even mostly runs, except `test_multiple_instances_with_same_pointer`, which segfaults because it is using a `unique_ptr` holder but `smart_holder` `type_caster`. Also adding `static_assert`s to generate build errors for such situations, but guarding with `#if 0` to first pivot to test_factory_constructors.cpp.

…s builds and runs with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT. Explanation why the const needs to be removed, or fix elsewhere, is still needed, but left for later.

…onstructors failure. Using py::class_ in this commit, to be changed to py::classh for debugging.

…keLists.txt, test_files.py (since it does not exist in this branch).

… tests.

…ctory_constructors feature parity for py::class_ and py::classh.

…onstruct(). With this test_factory_constructors.cpp builds with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT.

…USE_SMART_HOLDER_AS_DEFAULT for now, pending work on smart_holder_type_caster<shared_ptr>.

…Preparation for building with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT.

… not needed. Factoring out is_std_default_delete<T>() for consistentcy between ensure_compatible_rtti_uqp_del() and from_unique_ptr().

…est_smart_ptr.cpp. With this test_smart_ptr builds with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT and all but one test run successfully.

…and 2. default_holder_type, used in stl_bind.h.

… is not mixed with type_caster_base, and unique_ptr/shared_ptr holders are not mixed with smart_holder_type_casters.

…with this all but one test succeed with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT).

…ssert for "necessary conditions" for both types of default holder, static_assert for "strict conditions" guarded by new PYBIND11_STRICT_ASSERTS_CLASS_HOLDER_VS_TYPE_CASTER_MIX. All tests build & run as before with unique_ptr as the default holder, all tests build for smart_holder as the default holder, even with the strict static_assert.

…check, and reinterpreting record.default_holder as "uses_unique_ptr_holder". With this test_smart_ptr succeeds. (All 42 tests build, 35 tests succeed, 5 run but have some failures, 2 segfault.)

…his test_builtin_casters succeeds. (All 42 tests build, 36 tests succeed, 5 run but have some failures, 1 segfault.)

…r_generic_load_impl. This fixes the last remaining segfault (test_numpy_dtypes). New stats for all tests combined: 12 failed, 458 passed.

…__) into load_value_and_holder. Deferring destruction of disowned holder until clear_instance, to remain inspectable for "uninitialized" or "disowned" detection. New stats for all tests combined: 5 failed, 465 passed.

…. New stats for all tests combined: 4 failed, 466 passed.

…tr returns. New stats for all tests combined: 3 failed, 467 passed.

… all tests with ASAN. This version of the code is ASAN clean with unique_ptr or smart_holder as the default. This change needs to be reverted after adopting the existing move-only-if-refcount-is-1 logic used by type_caster_base.

…ation for a follow-up change in smart_holder_type_caster, to make this test sensitive to the changing behavior. [skip ci]

…tibility with the behavior of type_caster_base. Enables reverting 2 of 3 test manipulations applied under commit 249df7c. The manipulation in test_factory_constructors.py is NOT reverted in this commit. [skip ci]

…st manipulation in commit 249df7c and makes all existing unit tests pass with smart_holder as default holder.

…all errors, not just the first).

…ode simpler.

…c compilation errors. The only loss is pass_rref in test_class_sh_basic.

…th `typename std::enable_if<...smart_holder...>::type`. Attempt to work around MSVC 2015 issues, to be tested via GitHub CI. The idea for this change originates from this comment: pybind#1616 (comment)

…ting pytest first.

…older_as_default.

…r code more disconnected.

…ffectively reverting commit 5d4b689.

…it was an oversight that it was not removed with commit 23036a4).

…`. To make this possible, `operator T const&` and `operator T const*` in `smart_holder_type_caster` need to be marked as `const` member functions.

… unique_ptr, shared_ptr returns.

… (fixes oversight, this should have been added long before).

…ags (only the throw are not actually exercised, investing time there has a high cost but very little benefit).

…holder_type_casters_inline_include.h.

…thon_package/test_files.py.

…everal holders. Tested using github.com/rwgk/pybind11_scons and Google-internal build system. Sorry, no cmake support at the moment. First results: https://docs.google.com/spreadsheets/d/1InapCYws2Gt-stmFf_Bwl33eOMo3aLE_gc9adveY7RU/edit#gid=0

…ance data for PyCLIF.

[skip ci]

…sfinae_hooks_only.h.

…aster for clarity.

…_uses_smart_holder_type_caster for clarity.

…ster_base_tag for simplicity.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

testing smart_holder as default #2872

testing smart_holder as default #2872

Commits on Feb 23, 2021

Commits on Feb 24, 2021