Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved workaround for Centos 8 failure (follow-on to PR #3030). #3193

Merged
merged 4 commits into from
Aug 12, 2021

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Aug 12, 2021

The Centos 8 failure first observed back in June still exists, but somewhat coincidentally it was discovered that -DCMAKE_BUILD_TYPE=Release works (the default is MinSizeRel).

Also fixing a minor documentation bug.

@rwgk rwgk requested a review from henryiii as a code owner August 12, 2021 16:06
@Skylion007
Copy link
Collaborator

Still segfaulting unfortunately.

@rwgk
Copy link
Collaborator Author

rwgk commented Aug 12, 2021

Still segfaulting unfortunately.

Yeah, I'm very surprised. It worked under #3186, but in addition to the pragma-related changes there

  • I was using -DCMAKE_BUILD_TYPE=Release (meant to be an easier trick than a full rollback as in this PR).
  • I had the entire if(PYBIND11_WERROR) block in tests/CMakeLists.txt commented out.

I'm in the middle of experimenting under #3168 to find out what is the critical difference.

@rwgk
Copy link
Collaborator Author

rwgk commented Aug 12, 2021

  • -DCMAKE_BUILD_TYPE=Release

It turns out this is the critical difference (I'm surprised again).

The proof is in the latest CI run here. Before adding -DCMAKE_BUILD_TYPE=Release the Centos 8 job had the segfault, after adding it (and no other changes) the Centos 8 job fully succeeds.

@rwgk rwgk changed the title Rollback of PR #3030 (Working around Centos 8 failure). Improved workaround for Centos 8 failure (follow-on to PR #3030). Aug 12, 2021
@rwgk rwgk requested a review from Skylion007 August 12, 2021 19:37
@rwgk rwgk merged commit 7d3b057 into pybind:master Aug 12, 2021
@rwgk rwgk deleted the centos8_back_to_release branch August 12, 2021 20:21
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Aug 12, 2021
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants