Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update changelog, with target date for v2.11.0 release #4677

Merged
merged 7 commits into from
May 22, 2023

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented May 19, 2023

Description

We have a lot of accumulated changes. Proposed release date: June 2, 2023

Note for easy reference: v2.10.0 was released on Jul 15, 2022.

Please help proof-reading the changelog.

PRs to be merged before the release (please review or comment by June 2):

Suggested changelog entry:

@rwgk rwgk requested a review from henryiii as a code owner May 19, 2023 19:08
@rwgk rwgk requested a review from ax3l May 19, 2023 19:14
@henryiii
Copy link
Collaborator

henryiii commented May 20, 2023

I'll be doing some stuff for Pyodide support, would like to make sure that's working before a release - including a pyodide CI job I've been working on using out-of-tree testing using scikit-build-core (which is really cool, but broken by a bug in emscripten I'm working on). I'll be at the scientific-python developer summit all next week, and won't have much time to finish that up till after I expect, so targeting a time after that would be preferable, I think.

I have a feeling 2.10's date was related to SciPy.

Did you use nox to generate the (initial draft) of the changelog update?

``CMAKE_INTERPROCEDURAL_OPTIMIZATION`` is defined.
`#4643 <https://github.com/pybind/pybind11/pull/4643>`_

* No longer inject -stdlib=libc++, not needed for modern Pythons (macOS 10.9+).

This comment was marked as resolved.

* Introduce recursive_container_traits.
`#4623 <https://github.com/pybind/pybind11/pull/4623>`_

* pybind11/type_caster_pyobject_ptr.h was added to support automatic wrapping

This comment was marked as resolved.


Changes will be summarized here periodically.
* Introduce recursive_container_traits.

This comment was marked as resolved.

no longer converted to Python (only to be discarded).
`#4621 <https://github.com/pybind/pybind11/pull/4621>`_

* Allow lambda specified to function definition to be noexcept(true) in C++17.

This comment was marked as resolved.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied, thanks!

@rwgk
Copy link
Collaborator Author

rwgk commented May 20, 2023

so targeting a time after that would be preferable, I think.

I changed the target date to June 2, do you think that could work?

I don't have a direct interest in releases (I work against latest master everywhere), but the thought that people are spending hours debugging GIL issues unnecessarily makes me a bit sad; #4246 is still only on master, but in no release. I believe exactly the people who're likely to benefit the most, those with limited experience, will also be the ones least likely to work against master.

Did you use nox to generate the (initial draft) of the changelog update?

I looked, but then decided to simply try python3 tools/make_changelog.py and when that worked I didn't look any further. Thanks for the script btw, it eliminates a lot of the grunge work.

@rwgk
Copy link
Collaborator Author

rwgk commented May 22, 2023

I think the v2.11.0 release could also be a good opportunity to purge Python 3.6 support. End of life was already 23 Dec 2021, 1 year 4 months ago. That would get rid of all WITH_THREAD (see below).

I could do the work (I think it's only a couple hours), but

  • can someone think of reasons to continue Python 3.6 support?

  • Could someone please help reviewing with quick turnarounds (~24 hours)?

include/pybind11/embed.h:#    if defined(WITH_THREAD) && PY_VERSION_HEX < 0x03070000
include/pybind11/gil.h:#if defined(WITH_THREAD) && !defined(PYBIND11_SIMPLE_GIL_MANAGEMENT)
include/pybind11/gil.h:#if defined(WITH_THREAD)
include/pybind11/gil.h:#else // WITH_THREAD
include/pybind11/gil.h:#endif // WITH_THREAD
include/pybind11/detail/type_caster_base.h:#if defined(WITH_THREAD)
include/pybind11/detail/common.h:// Reminder: WITH_THREAD is always defined if PY_VERSION_HEX >= 0x03070000
include/pybind11/detail/internals.h:#if defined(WITH_THREAD) && defined(PYBIND11_SIMPLE_GIL_MANAGEMENT)
include/pybind11/detail/internals.h:#if defined(WITH_THREAD)
include/pybind11/detail/internals.h:#    if defined(WITH_THREAD)
include/pybind11/detail/internals.h:#if defined(WITH_THREAD)
include/pybind11/detail/internals.h:#if defined(WITH_THREAD)
include/pybind11/detail/internals.h:#if defined(WITH_THREAD) && PYBIND11_INTERNALS_VERSION == 4
include/pybind11/detail/internals.h:#endif //  defined(WITH_THREAD) && PYBIND11_INTERNALS_VERSION == 4
tests/test_call_policies.cpp:#if defined(WITH_THREAD) && !defined(PYPY_VERSION)

@henryiii
Copy link
Collaborator

Since 2.11 is almost out and all the work is already there to keep in on 3.6, would it be better to drop 3.6 right after? No strong reason to keep supporting imo, only manylinux is left still supporting 3.6.

Could you drop the Version number change them merge? That way the labels can be cleared before new PRs are added (like the notes one).

First beta of 3.12 is out soon!

@rwgk
Copy link
Collaborator Author

rwgk commented May 22, 2023

Since 2.11 is almost out and all the work is already there to keep in on 3.6, would it be better to drop 3.6 right after? No strong reason to keep supporting imo, only manylinux is left still supporting 3.6.

Sounds good. That way it'll live ~1 year longer in the latest release series, but won't bother us anymore on master.

Could you drop the Version number change them merge?

Dropped and ready to merge (I'll change the title first).

That way the labels can be cleared

Do we clear them manually?

First beta of 3.12 is out soon!

With cpython main from a few hours ago the pybind11 unit tests only build, pytest dies at startup: python/cpython#103912 (comment)

@rwgk rwgk changed the title chore: Prepare for v2.11.0 release. chore: update changelog, with target date for v2.11.0 release May 22, 2023
@rwgk rwgk merged commit 19816f0 into pybind:master May 22, 2023
@rwgk rwgk deleted the prep_v2.11.0 branch May 22, 2023 20:44
@rwgk
Copy link
Collaborator Author

rwgk commented May 22, 2023

First beta of 3.12 is out soon!

It is out now, with two bugs I knew about ahead of time, which means we cannot do much with 3.12 beta 1 :-(

One bug is fixed already (even before the cut but it was too late anyway).

The other I/we still have to figure out.

@rwgk
Copy link
Collaborator Author

rwgk commented May 22, 2023

That way the labels can be cleared

Do we clear them manually?

Easy enough: done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants