Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eigen] Obey noconvert() in Eigen::Sparse type_caster #4937

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EricCousineau-TRI
Copy link
Collaborator

Description

This is forwarding a fix from @jwnimmer-tri from our Drake fork (RobotLocomotion#69).
See RobotLocomotion/drake#20516 for how it affected us.

Suggested changelog entry:

Obey noconvert() in Eigen::Sparse type_caster

@rwgk
Copy link
Collaborator

rwgk commented Nov 12, 2023

Hi @EricCousineau-TRI, lgtm, but could you please also add a test that fails without this change?

Copy link
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I agree a test case would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants