Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal/sagas: fix handling multibyte unicode #2310

Merged
merged 1 commit into from
Sep 8, 2024
Merged

terminal/sagas: fix handling multibyte unicode #2310

merged 1 commit into from
Sep 8, 2024

Conversation

dlech
Copy link
Member

@dlech dlech commented Sep 8, 2024

Enable the stream option on the text decode for the stdout and uart stream handlers that pipe data to the terminal. This fixes improperly printing multibyte unicode characters that get split across multiple data packets.

A new decode is added for each different stream in case both are used at the same time.

Fixes: pybricks/support#1743

Enable the stream option on the text decode for the stdout and uart
stream handlers that pipe data to the terminal. This fixes improperly
printing multibyte unicode characters that get split across multiple
data packets.

A new decode is added for each different stream in case both are used
at the same time.

Fixes: pybricks/support#1743
@dlech dlech enabled auto-merge (rebase) September 8, 2024 22:48
@dlech dlech merged commit baaa9a7 into master Sep 8, 2024
4 checks passed
@dlech dlech deleted the dlech branch September 8, 2024 22:52
@laurensvalk
Copy link
Member

谢谢!

@angzicn
Copy link

angzicn commented Sep 13, 2024

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pybricks Code hub stdout to terminal is not UTF-8 aware
3 participants