Build Arm64 container for Manylinux2014_aarch64

[geoffreyblake]

Containers not supported Arm64

• Alpine Linux -- missing rustup precompiled binary on rust-lang site
• manylinux1 -- x86 only
• manylinux2010 -- x86 only

Remaining containers are built using buildx inside github actions to push a manifest to the docker repository to allow tags to contain multiple architectures. Doing a docker pull on x86 or Arm64 machines will pull the expected container.

Tested in my own docker account and see all the containers with both x86 and arm64 hashes.

[alex]

Do you know if there's a bug on the rust side for getting aarch64-unknown-linux-musl rustc builds?

[geoffreyblake]

There is no artifact for aarch64-unknown-linux-musl, and rust also omits it as a supported binary: https://forge.rust-lang.org/infra/other-installation-methods.html

[alex]

Would you be up for filing a bug requesting it? If not, I can do it.

…

On Tue, Aug 18, 2020 at 6:05 PM Geoffrey Blake ***@***.***> wrote: There is no artifact for aarch64-unknown-linux-musl, and rust also omits it as a supported binary: https://forge.rust-lang.org/infra/other-installation-methods.html — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#297 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBGPG6WQ5Y7TFVIBXHTSBL3KHANCNFSM4QEDEPEQ> .

-- All that is necessary for evil to succeed is for good people to do nothing.

[geoffreyblake]

If you know the issue tracker to file it against, just give me the link and I can file it. On Tue, Aug 18, 2020 at 5:57 PM Alex Gaynor <[email protected]> wrote:

…

Would you be up for filing a bug requesting it? If not, I can do it. On Tue, Aug 18, 2020 at 6:05 PM Geoffrey Blake ***@***.***> wrote: > There is no artifact for aarch64-unknown-linux-musl, and rust also omits > it as a supported binary: > https://forge.rust-lang.org/infra/other-installation-methods.html > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#297 (comment)>, or > unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAAAGBGPG6WQ5Y7TFVIBXHTSBL3KHANCNFSM4QEDEPEQ > > . > -- All that is necessary for evil to succeed is for good people to do nothing. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#297 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGGEKOCXX2EYQN7V5O6OBHLSBMBM7ANCNFSM4QEDEPEQ> .

[alex]

Pretty sure it'd be https://github.com/rust-lang/rust Thanks! On Tue, Aug 18, 2020 at 7:07 PM Geoffrey Blake <[email protected]> wrote:

…

If you know the issue tracker to file it against, just give me the link and I can file it. On Tue, Aug 18, 2020 at 5:57 PM Alex Gaynor ***@***.***> wrote: > > > > Would you be up for filing a bug requesting it? If not, I can do it. > > > > > > > > On Tue, Aug 18, 2020 at 6:05 PM Geoffrey Blake ***@***.*** > > > > > wrote: > > > > > > > > > There is no artifact for aarch64-unknown-linux-musl, and rust also omits > > > > > it as a supported binary: > > > > > https://forge.rust-lang.org/infra/other-installation-methods.html > > > > > > > > > > — > > > > > You are receiving this because you commented. > > > > > Reply to this email directly, view it on GitHub > > > > > <#297 (comment)>, or > > > > > unsubscribe > > > > > < > https://github.com/notifications/unsubscribe-auth/AAAAGBGPG6WQ5Y7TFVIBXHTSBL3KHANCNFSM4QEDEPEQ > > > > > > > . > > > > > > > > > > > > > > > > > -- > > > > All that is necessary for evil to succeed is for good people to do nothing. > > > > > > > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#297 (comment)>, or > unsubscribe > < https://github.com/notifications/unsubscribe-auth/AGGEKOCXX2EYQN7V5O6OBHLSBMBM7ANCNFSM4QEDEPEQ > > . > > > > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#297 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBF54SLY2W6NAILHWI3SBMCUHANCNFSM4QEDEPEQ> .

-- All that is necessary for evil to succeed is for good people to do nothing.

[geoffreyblake]

Already an issue open for the past year 😕. rust-lang/rustup#2003 Appears there is more work required than simply turning on the build. On Tue, Aug 18, 2020 at 6:09 PM Alex Gaynor <[email protected]> wrote:

…

Pretty sure it'd be https://github.com/rust-lang/rust Thanks! On Tue, Aug 18, 2020 at 7:07 PM Geoffrey Blake ***@***.***> wrote: > If you know the issue tracker to file it against, just give me the link and > I can file it. > > On Tue, Aug 18, 2020 at 5:57 PM Alex Gaynor ***@***.***> > wrote: > > > > > > > > > Would you be up for filing a bug requesting it? If not, I can do it. > > > > > > > > > > > > > > > > On Tue, Aug 18, 2020 at 6:05 PM Geoffrey Blake < ***@***.*** > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > There is no artifact for aarch64-unknown-linux-musl, and rust also > omits > > > > > > > > > it as a supported binary: > > > > > > > > > https://forge.rust-lang.org/infra/other-installation-methods.html > > > > > > > > > > > > > > > > > > — > > > > > > > > > You are receiving this because you commented. > > > > > > > > > Reply to this email directly, view it on GitHub > > > > > > > > > <#297 (comment)>, or > > > > > > > > > unsubscribe > > > > > > > > > < > > > https://github.com/notifications/unsubscribe-auth/AAAAGBGPG6WQ5Y7TFVIBXHTSBL3KHANCNFSM4QEDEPEQ > > > > > > > > > > > > . > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > All that is necessary for evil to succeed is for good people to do > nothing. > > > > > > > > > > > > > > > > > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub > > <#297 (comment)>, or > > unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AGGEKOCXX2EYQN7V5O6OBHLSBMBM7ANCNFSM4QEDEPEQ > > > > . > > > > > > > > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#297 (comment)>, or > unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAAAGBF54SLY2W6NAILHWI3SBMCUHANCNFSM4QEDEPEQ > > . > -- All that is necessary for evil to succeed is for good people to do nothing. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#297 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGGEKODPPBZHSJZT34EFCBTSBMCZFANCNFSM4QEDEPEQ> .

[alex]

Thanks. Can you add a link to that issue in a comment. On Tue, Aug 18, 2020 at 8:01 PM Geoffrey Blake <[email protected]> wrote:

…

Already an issue open for the past year 😕. rust-lang/rustup#2003 Appears there is more work required than simply turning on the build. On Tue, Aug 18, 2020 at 6:09 PM Alex Gaynor ***@***.***> wrote: > > > > Pretty sure it'd be https://github.com/rust-lang/rust > > > > > > > > Thanks! > > > > > > > > On Tue, Aug 18, 2020 at 7:07 PM Geoffrey Blake ***@***.*** > > > > > wrote: > > > > > > > > > If you know the issue tracker to file it against, just give me the link > and > > > > > I can file it. > > > > > > > > > > On Tue, Aug 18, 2020 at 5:57 PM Alex Gaynor ***@***.***> > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Would you be up for filing a bug requesting it? If not, I can do it. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Aug 18, 2020 at 6:05 PM Geoffrey Blake < > ***@***.*** > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > There is no artifact for aarch64-unknown-linux-musl, and rust also > > > > > omits > > > > > > > > > > > > > > > > > > > > > > > > > it as a supported binary: > > > > > > > > > > > > > > > > > > > > > > > > > https://forge.rust-lang.org/infra/other-installation-methods.html > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > — > > > > > > > > > > > > > > > > > > > > > > > > > You are receiving this because you commented. > > > > > > > > > > > > > > > > > > > > > > > > > Reply to this email directly, view it on GitHub > > > > > > > > > > > > > > > > > > > > > > > > > <#297 (comment)>, or > > > > > > > > > > > > > > > > > > > > > > > > > unsubscribe > > > > > > > > > > > > > > > > > > > > > > > > > < > > > > > > > > > > > > https://github.com/notifications/unsubscribe-auth/AAAAGBGPG6WQ5Y7TFVIBXHTSBL3KHANCNFSM4QEDEPEQ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > . > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > All that is necessary for evil to succeed is for good people to do > > > > > nothing. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > — > > > > > > You are receiving this because you authored the thread. > > > > > > Reply to this email directly, view it on GitHub > > > > > > <#297 (comment)>, or > > > > > > unsubscribe > > > > > > < > > > > > > https://github.com/notifications/unsubscribe-auth/AGGEKOCXX2EYQN7V5O6OBHLSBMBM7ANCNFSM4QEDEPEQ > > > > > > > > > > > > . > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > — > > > > > You are receiving this because you commented. > > > > > Reply to this email directly, view it on GitHub > > > > > <#297 (comment)>, or > > > > > unsubscribe > > > > > < > https://github.com/notifications/unsubscribe-auth/AAAAGBF54SLY2W6NAILHWI3SBMCUHANCNFSM4QEDEPEQ > > > > > > > . > > > > > > > > > > > > > > > > > -- > > > > All that is necessary for evil to succeed is for good people to do nothing. > > > > > > > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#297 (comment)>, or > unsubscribe > < https://github.com/notifications/unsubscribe-auth/AGGEKODPPBZHSJZT34EFCBTSBMCZFANCNFSM4QEDEPEQ > > . > > > > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#297 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBHGKOPMVMIJWZPA42LSBMI6HANCNFSM4QEDEPEQ> .

-- All that is necessary for evil to succeed is for good people to do nothing.

[geoffreyblake]

Need to correct this issue: pypa/manylinux#735
Before pushing these container builds.

[geoffreyblake]

This PR is outstanding to fix the root cause of failed Arm builds: pypa/manylinux#739

[geoffreyblake]

pypa/manylinux#739 has been merged and the new manylinux2014_aarch64 container has been uploaded. Is there anything else @alex you need to see in this PR before merging?

[reaperhulk]

Right now we don't have an intention to test against aarch64 docker images. We may do that in the future so it's very helpful to see a path to building those sanely, but for the moment the only docker image I think we need is manylinux2014 aarch64. If you could update this PR to just do that for the moment we can get that merged quickly.

[geoffreyblake]

Any reason why you don't want all the containers done now? I'll update this with just the manylinux part for now.

[geoffreyblake]

@reaperhulk , changes backed out and just the manylinux2014_aarch64 is there. Let me know if there are other changes needed.

[reaperhulk]

In general we try not to have infrastructure/artifacts/builds that we don't use. Given the size of our CI it makes it difficult to reason about everything if there are pieces that are part of the machinery but aren't being used. I've created the docker hub repo for the new manylinux2014 image so we should be set for merge and push. Let's see how it goes 😄

[geoffreyblake]

That makes sense to a degree, but as we inch closer to an aarch64 release, I would suspect you want to test on the platforms you support as much as possible. But for now I'm happy to get the manylinux2014 container in, now its possible to build the wheels.

[alex]

We're currently testing with aarch64 on Ubuntu focal, binoc, and CentOS 8, we're just not using docker for it.

…

On Wed, Aug 26, 2020 at 6:11 PM Geoffrey Blake ***@***.***> wrote: That makes sense to a degree, but as we inch closer to an aarch64 release, I would suspect you want to test on the platforms you support as much as possible. But for now I'm happy to get the manylinux2014 container in, now its possible to build the wheels. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#297 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBABYLERVDEWCDCRRHDSCWB7ZANCNFSM4QEDEPEQ> .

-- All that is necessary for evil to succeed is for good people to do nothing.