Improvements to sync_folder_to_container speed, feature and verbose logging #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to specify a prefix to be added to the object name during checking and uploading during a sync Sped up sync_folder_to_container by having it pull down a list of objects all at once to use to compare against instead of checking once for each file.
| prefix="imgFolder") it will upload the files to the | ||
| container/imgFolder/... instead of just container/... | ||
|
|
||
| Set `log_level` to > 0 to print what is going on. Log level 1 logs |
There was a problem hiding this comment.
I really like the idea of visibility into the process. I would suggest using the existing pyrax logging:
logger = logging.getLogger("pyrax")
I also think that a better name for this parameter would be 'verbose', drop the different levels, and make it default to False. If someone is interested in the progress of the sync, having the one extra line of output isn't prohibitive.
|
I've added some comments on your code. In general I think this looks like an excellent addition to pyrax. Thanks for working on this! |
…h the existing prarameter called prefix which I restored. Changed to use the python logging method instead of using print statements. Renamed log_level to verbose and changed it to a simple boolean variable.
|
Thanks for the review and tips. I have made the recommended changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first open source code submission so please let me know if I am doing anything wrong. Which it looks like I did. This is my second attempt.
I added two features to sync_folder_to_container.
I added verbose logging to sync_folder_to_container while I was in there. #250