-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add excluded_urls
example for /
#487
base: main
Are you sure you want to change the base?
Conversation
Deploying logfire-docs with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 132 132
Lines 9944 9959 +15
Branches 1333 1338 +5
=========================================
+ Hits 9944 9959 +15 ☔ View full report in Codecov by Sentry. |
1f1bde2
to
a0f7997
Compare
Co-authored-by: David Montague <[email protected]>
Co-authored-by: David Montague <[email protected]>
Maybe this should be a section under https://logfire.pydantic.dev/docs/integrations/use-cases/web-frameworks/ which is linked to from specific integrations the way that capturing headers is, since this applies to other integrations as well, not just fastapi. |
Co-authored-by: David Montague <[email protected]>
Didn't get to this one today, will apply these suggestions tomorrow! Thanks for the feedback, folks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 files reviewed, 2 total issue(s) found.
The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:
- [Rr]egexes
@alexmojaki, should be ready for review again 👍 |
Closes #474