use pydantic's version in error messages

[davidhewitt]

Change Summary

As pydantic and pydantic-core versions have decoupled, when rendering errors we should use the pydantic package error messages, if available.

Related issue number

N/A

Checklist

• Unit tests for the changes exist
• Documentation reflects the changes where applicable
• Pydantic tests pass with this pydantic-core (except for expected changes)
• My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

[codspeed-hq]

CodSpeed Performance Report

Merging #759 will not alter performances

_{Comparing dh/error-versions (8355b71) with main (dfbedbd)}

Summary

✅ 126 untouched benchmarks

[davidhewitt]

please review

[adriangb]

Just a thought after we merged this: wouldn't it be simpler and make more sense to require an error_url_format_template: str or something like that in the validate_* methods so that pydantic can change the error URL without impacting pydantic-core (including setting the version)?

[adriangb]

Because now this PR means that pydantic-core has "some knowledge" of pydantic and pedantic obviously has knowledge of pydantic-core, so it's very much a circular dependency. Not to mention pydantic-core is totally unusable without pydantic, which make the whole point of having a separate package seem totally absurd.

[davidhewitt]

Just a thought after we merged this: wouldn't it be simpler and make more sense to require an error_url_format_template: str or something like that in the validate_* methods so that pydantic can change the error URL without impacting pydantic-core (including setting the version)?

Sure, can you give me a little bit more detail on how this might all hang together? I could take a look at moving to that pattern if it seems reasonable.

[adriangb]

I was thinking add an argument to SchemaValidator.validate_python and validate_json that has some sort of string format template (ideally one that is meaningful in both Python and rust). Then pydantic would do SchemaValidator(...).validate_python(..., error_template_url=ERROR_TEMPLATE_URL) where ERROR_TEMPLATE_URL is some global along the lines of ERROR_TEMPLATE_URL=f'https://pydantic.dev/{__version__}/errors/{error_type}/). Not sure if that would fully work or make sense, but it does seem like it'd be simpler and result in less circular dependencies between the pakcages.