Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config values as default in PydanticBaseEnvSettingsSource.__init__ #100

Merged
merged 2 commits into from
Jul 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pydantic_settings/sources.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ def __init__(
self, settings_cls: type[BaseSettings], case_sensitive: bool | None = None, env_prefix: str | None = None
) -> None:
super().__init__(settings_cls)
self.case_sensitive = case_sensitive if case_sensitive is not None else False
self.env_prefix = env_prefix if env_prefix is not None else ''
self.case_sensitive = case_sensitive if case_sensitive is not None else self.config.get('case_sensitive', False)
self.env_prefix = env_prefix if env_prefix is not None else self.config.get('env_prefix', '')

def _apply_case_sensitive(self, value: str) -> str:
return value.lower() if not self.case_sensitive else value
Expand Down
19 changes: 19 additions & 0 deletions tests/test_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
InitSettingsSource,
PydanticBaseSettingsSource,
SecretsSettingsSource,
SettingsConfigDict,
)
from pydantic_settings.sources import SettingsError, read_env_file

Expand Down Expand Up @@ -1698,3 +1699,21 @@ class Settings(BaseSettings):
'input': 'bar',
}
]


def test_custom_env_source_default_values_from_config():
class CustomEnvSettingsSource(EnvSettingsSource):
pass

class Settings(BaseSettings):
foo: str = 'test'

model_config = SettingsConfigDict(env_prefix='prefix_', case_sensitive=True)

s = Settings()
assert s.model_config['env_prefix'] == 'prefix_'
assert s.model_config['case_sensitive'] is True

c = CustomEnvSettingsSource(Settings)
assert c.env_prefix == 'prefix_'
assert c.case_sensitive is True