Check union args to don't consider Optional fields as complex Union #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 97.46% 97.47% +0.01%
==========================================
Files 5 5
Lines 315 317 +2
Branches 68 69 +1
==========================================
+ Hits 307 309 +2
Misses 6 6
Partials 2 2
☔ View full report in Codecov by Sentry. |
hramezani
force-pushed
the
check-union-is-complex
branch
2 times, most recently
from
9059838
to
8d2b3d9
Compare
hramezani
force-pushed
the
check-union-is-complex
branch
from
8d2b3d9
to
0ae846f
Compare
|
please review |
dmontagu
reviewed
Aug 7, 2023
tests/test_settings.py
Outdated
| data: Optional[Json[Dict[str, str]]] = Field(default=None) | ||
|
|
||
| s = Settings() | ||
| print(s.data) |
There was a problem hiding this comment.
Suggested change
| print(s.data) |
dmontagu
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #135
Closes #136
Selected Reviewer: @samuelcolvin