Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm Python 3.12 support #174

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Confirm Python 3.12 support #174

merged 3 commits into from
Nov 8, 2023

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Oct 5, 2023

Selected Reviewer: @dmontagu

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e529615) 97.45% compared to head (54a60a3) 97.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files           5        5           
  Lines         314      314           
  Branches       69       69           
=======================================
  Hits          306      306           
  Misses          6        6           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hramezani
Copy link
Member Author

please review

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hramezani hramezani merged commit ca7183c into main Nov 8, 2023
23 checks passed
@hramezani hramezani deleted the python312 branch November 8, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants