Replace tomlkit with tomli and remove toml_file_encoding config #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 97.63% 97.14% -0.49%
==========================================
Files 5 5
Lines 422 420 -2
Branches 89 89
==========================================
- Hits 412 408 -4
- Misses 7 9 +2
Partials 3 3 ☔ View full report in Codecov by Sentry. |
hramezani
force-pushed
the
fix-toml
branch
2 times, most recently
from
25338de
to
39d6b2c
Compare
I think we don't need to fall back on tomlkit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235
tomlkitwithtomliremove toml_file_encodingconfig because file open in binary mode doesn't take an encoding argument