Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli_exit_on_error config option #340

Merged
merged 10 commits into from
Jul 19, 2024

Conversation

kschwab
Copy link
Contributor

@kschwab kschwab commented Jul 10, 2024

Fixes #336

@kschwab kschwab marked this pull request as draft July 10, 2024 15:01
@kschwab kschwab changed the title Remove CLI exit on error and raise SettingsError instead. Add cli_exit_on_error config option Jul 10, 2024
@kschwab kschwab marked this pull request as ready for review July 10, 2024 15:47
@hramezani
Copy link
Member

@kschwab are you done?
@mpkocher do you want to take a look at this PR?

@kschwab
Copy link
Contributor Author

kschwab commented Jul 19, 2024

@hramezani yes, no more changes for this PR. It's ready to go.

@hramezani hramezani merged commit 4840d69 into pydantic:main Jul 19, 2024
18 checks passed
@hramezani
Copy link
Member

Thanks @kschwab

mr-kamran-ali referenced this pull request in robert-koch-institut/mex-common Aug 8, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [pydantic-settings](https://togithub.com/pydantic/pydantic-settings)
([changelog](https://togithub.com/pydantic/pydantic-settings/releases))
| project.dependencies | minor | `==2.3.4` -> `==2.4.0` |

---

### Release Notes

<details>
<summary>pydantic/pydantic-settings (pydantic-settings)</summary>

###
[`v2.4.0`](https://togithub.com/pydantic/pydantic-settings/releases/tag/v2.4.0)

[Compare
Source](https://togithub.com/pydantic/pydantic-settings/compare/v2.3.4...v2.4.0)

#### What's Changed

- Fix regex flags accidentally passed as count by
[@&#8203;musicinmybrain](https://togithub.com/musicinmybrain) in
[https://github.com/pydantic/pydantic-settings/pull/328](https://togithub.com/pydantic/pydantic-settings/pull/328)
- Deprecate `read_env_file` and move it to `DotEnvSettingsSource` by
[@&#8203;WarpedPixel](https://togithub.com/WarpedPixel) in
[https://github.com/pydantic/pydantic-settings/pull/318](https://togithub.com/pydantic/pydantic-settings/pull/318)
- Fix a bug when loading empty yaml file by
[@&#8203;hramezani](https://togithub.com/hramezani) in
[https://github.com/pydantic/pydantic-settings/pull/330](https://togithub.com/pydantic/pydantic-settings/pull/330)
- feat: Enable access to the current state in settings sources by
[@&#8203;VictorColomb](https://togithub.com/VictorColomb) in
[https://github.com/pydantic/pydantic-settings/pull/326](https://togithub.com/pydantic/pydantic-settings/pull/326)
- Add support for short options. by
[@&#8203;kschwab](https://togithub.com/kschwab) in
[https://github.com/pydantic/pydantic-settings/pull/339](https://togithub.com/pydantic/pydantic-settings/pull/339)
- Add Azure Key Vault settings source by
[@&#8203;AndreuCodina](https://togithub.com/AndreuCodina) in
[https://github.com/pydantic/pydantic-settings/pull/272](https://togithub.com/pydantic/pydantic-settings/pull/272)
- Add cli_exit_on_error config option by
[@&#8203;kschwab](https://togithub.com/kschwab) in
[https://github.com/pydantic/pydantic-settings/pull/340](https://togithub.com/pydantic/pydantic-settings/pull/340)

#### New Contributors

- [@&#8203;musicinmybrain](https://togithub.com/musicinmybrain) made
their first contribution in
[https://github.com/pydantic/pydantic-settings/pull/328](https://togithub.com/pydantic/pydantic-settings/pull/328)
- [@&#8203;WarpedPixel](https://togithub.com/WarpedPixel) made their
first contribution in
[https://github.com/pydantic/pydantic-settings/pull/318](https://togithub.com/pydantic/pydantic-settings/pull/318)
- [@&#8203;VictorColomb](https://togithub.com/VictorColomb) made their
first contribution in
[https://github.com/pydantic/pydantic-settings/pull/326](https://togithub.com/pydantic/pydantic-settings/pull/326)
- [@&#8203;AndreuCodina](https://togithub.com/AndreuCodina) made their
first contribution in
[https://github.com/pydantic/pydantic-settings/pull/272](https://togithub.com/pydantic/pydantic-settings/pull/272)

**Full Changelog**:
pydantic/pydantic-settings@v2.3.4...v2.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjEuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
@kschwab kschwab deleted the remove_cli_system_exit branch August 16, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SystemExit usage
2 participants