Put tests for non-default sources in separate files #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hramezani ready for review. GitHub lint check fails on code that I didn't modify, although local |
hramezani
reviewed
Sep 30, 2024
hramezani
force-pushed
the
tests-refactoring
branch
2 times, most recently
from
52c4f5e
to
7eb9f46
Compare
hramezani
force-pushed
the
tests-refactoring
branch
from
7eb9f46
to
fe3b10d
Compare
hramezani
approved these changes
Sep 30, 2024
|
Thanks @makukha |
|
@hramezani I'm glad to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427.
Tests for settings sources, that are turned on by default, reside untouched in
test_settings.py:DotEnvSettingsSource,EnvSettingsSource,InitSettingsSource,SecretsSettingsSource.Tests for other sources are moved to separate files.