-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve DotenvType
to accept str
#96
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 5 5
Lines 311 311
Branches 68 68
=======================================
Hits 303 303
Misses 6 6
Partials 2 2
☔ View full report in Codecov by Sentry. |
2297b66
to
96ecb61
Compare
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't test these?
We have some tests that include the string Which kind of tests do you mean? |
Any test that would avoid a regression here. 👀 |
It's a mypy error and we don't have mypy tests here.
|
Fixes first error reported in #95
Selected Reviewer: @samuelcolvin