Immutability part 2 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 704 779 +75
Branches 157 187 +30
=====================================
+ Hits 704 779 +75 |
samuelcolvin
force-pushed
the
immutability-2
branch
from
7dd393c
to
ea38c29
Compare
samuelcolvin
force-pushed
the
immutability-2
branch
from
6125b38
to
d63cee9
Compare
samuelcolvin
force-pushed
the
immutability-2
branch
from
8332412
to
d9c31c7
Compare
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
* attempt at implementing __reduce__ * python version * remove loc * back to rust * use array * minimize changes * again use array * remove import * test all protocol versions * Update src/validators/mod.rs Co-authored-by: Samuel Colvin <[email protected]> * Update src/validators/mod.rs Co-authored-by: Samuel Colvin <[email protected]> * pr feedback * pointlessly tweak layout Co-authored-by: Samuel Colvin <[email protected]> Co-authored-by: Samuel Colvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #40 and #48
#44 was in chocolate teapot territory without the potential to copy models, this should allow it.