-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrivateAttr
is passed from Annotated
default position
#8004
Merged
Commits on Nov 3, 2023
-
PrivateAttr
is passed fromAnnotated
default positionCo-authored-by: Samuel Colvin <[email protected]> <!-- Thank you for your contribution! --> <!-- Unless your change is trivial, please create an issue to discuss the change before creating a PR --> ## Change Summary See related issue for a minimal example. - When creating private fields from typing.Annotated, the default method gets thrown out in the current implementation. - This Pull-Requests adds functionality to check wether the Default in the `Anntotated[]` definition already is a `PrivateAttr` and uses it straight away. ## Related issue number fix pydantic#7955 ## Checklist * [ ] The pull request title is a good summary of the changes - it will be used in the changelog * [ ] Unit tests for the changes exist * [ ] Tests pass on CI * [ ] Documentation reflects the changes where applicable * [ ] My PR is ready to review, **please add a comment including the phrase "please review" to assign reviewers**
Tim Kreitner committedNov 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 175901c - Browse repository at this point
Copy the full SHA 175901cView commit details -
more specific checking for annotated type
Tim Kreitner committedNov 3, 2023 Configuration menu - View commit details
-
Copy full SHA for ee91d87 - Browse repository at this point
Copy the full SHA ee91d87View commit details -
Tim Kreitner committed
Nov 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 0214ac2 - Browse repository at this point
Copy the full SHA 0214ac2View commit details -
Tim Kreitner committed
Nov 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 1b6e2f6 - Browse repository at this point
Copy the full SHA 1b6e2f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0431d02 - Browse repository at this point
Copy the full SHA 0431d02View commit details -
Configuration menu - View commit details
-
Copy full SHA for fca864f - Browse repository at this point
Copy the full SHA fca864fView commit details -
Merge remote-tracking branch 'upstream/fix-ruff-migration-issues' int…
…o 7955-fix-attr-error
Tim Kreitner committedNov 3, 2023 Configuration menu - View commit details
-
Copy full SHA for e50f9a7 - Browse repository at this point
Copy the full SHA e50f9a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7074a48 - Browse repository at this point
Copy the full SHA 7074a48View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff9c789 - Browse repository at this point
Copy the full SHA ff9c789View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.