Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup.py to respect numpy's parsing of libraries in site.cfg #443

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

de11n
Copy link
Contributor

@de11n de11n commented Jul 28, 2023

numpy parses libraries in site.cfg by splitting on comma. We want to maintain compatibility with that, but we've already established os.pathname by accident. To minimize breakages, we support both.

Fixes #407

numpy parses libraries in site.cfg by splitting on comma. We want to
maintain compatibility with that, but we've already established
os.pathname by accident. To minimize breakages, we support both.
@robbmcleod
Copy link
Member

Thanks.

@robbmcleod robbmcleod merged commit 67a1221 into pydata:master Aug 6, 2023
9 checks passed
@de11n de11n deleted the fix-libraries-parsing branch August 7, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong separator for MKL libraries in setup.py?
2 participants