-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: use a function to test the warnings of the CI doc build #1002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice, thanks - just a few quick comments. I'll also push a commit to clean up the language a bit, hope that's OK
WARNING: image file not readable: _static/gallery/feature-engine.png | ||
WARNING: image file not readable: _static/gallery/arviz.png | ||
WARNING: image file not readable: _static/gallery/sepal.png | ||
WARNING: image file not readable: _static/gallery/enoslib.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is going to get tedious because every new image here will create toil where we have to update these warnings. Could we allow this to support glob-like patterns and then do _static/gallery/*
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the advantage here is that in 1 loop as I pop the element from the list I get both missing
and unexpected
. We already have a lot of examples in the gallery do you really expect it to increase that much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe not - let's not block this PR on that question, we can revisit if it becomes cumbersome or if people forget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple quick thoughts, this is looking pretty good to me though!
WARNING: image file not readable: _static/gallery/feature-engine.png | ||
WARNING: image file not readable: _static/gallery/arviz.png | ||
WARNING: image file not readable: _static/gallery/sepal.png | ||
WARNING: image file not readable: _static/gallery/enoslib.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe not - let's not block this PR on that question, we can revisit if it becomes cumbersome or if people forget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this improvement to the maintainability of the theme!
FIX #937
new stuff:
WARNING
orERROR
) to avoid issue with directory name (nox, not nox, hosted, virtualenv) and the file seperator between Linux and WindowsLet me know what you think