Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style dataframe included in a widget #1089

Merged
merged 3 commits into from
Dec 23, 2022

Conversation

12rambau
Copy link
Collaborator

add the jp-RenderedHTMLCommon special case from nbsphinx custom styling to get the "auto" layout when table are embeded in a widget as well.

Fix #1063

an example from the initial issue (https://github.com/ClementPinard/pydata-nbsphinx-pandas-bug-example) built with this PR:

Capture d’écran 2022-12-19 à 23 35 37

@12rambau 12rambau marked this pull request as ready for review December 20, 2022 06:40
@12rambau
Copy link
Collaborator Author

@choldgraf I coorected the matplotlib issue in #1091 and it has been merged in main, why isn't it updating the test in this PR as well ? (I think everything should be green now)

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just merge it - we know this has been fixed and it is a small change. I know it's not best practice but I think it's ok here 🙂

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inproper styling of dataframes for nbsphinx + pydata theme when contained in ipywidget
2 participants