Fix typos found by codespell

[DimitriPapadopoulos]

No description provided.

[drammock]

@DimitriPapadopoulos want to add codespell to our CI config?

[DimitriPapadopoulos]

I can do that if you're willing to live with the downsides:

• false positives need to be silenced by a list of words to ignore
• new false positives may appear all of a sudden because new typos have been added to codespell dictionaries, including in patch releases

[12rambau]

One of the typo you identifed was in kitchen sink which is inherited from the sphinx-theme website. I reported it upstream.

[drammock]

One of the typo you identifed was in kitchen sink which is inherited from the sphinx-theme website. I reported it upstream.

ooh, good catch. we shouldn't be modifying kitchen sink here.

[12rambau]

instead of adding it to tests, would it be preferable to add it to the pre-commit ? they have a hook and this would make sure any commit is already checked + we are already checking the pre-commits in the tests

[DimitriPapadopoulos]

Yes, probably better in pre-commit. Unfortunately I don't have much experience with pre-commit, because of previous bad experience with it (lots of compatibility issues I didn't have time to debug on my Ubuntu 18.04 machine). I'll give it a try.

[DimitriPapadopoulos]

Among other annoyances, pre-commit doesn't work on Ubuntu 22.04 by default:

return code: 1
expected return code: 0
stdout:
    Executable `python` not found
stderr: (none)

Easily fixed with:

sudo apt install python-is-python3 

Buit then I get this new error:

An unexpected error has occurred: AssertionError: BUG: expected environment for python to be healthy() immediately after install, please open an issue describing your environment

I find pre-commit is a pain to use locally.

[drammock]

let's roll back the CI addition and address adding codespell to pre-commit in a separate PR. No need to drag out the simpler changes. (please also revert the change to kitchen sink too, if you haven't already).

[DimitriPapadopoulos]

I have reverted the CI/pre-commit stuff.