Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Section on RTD version switcher #1280

Merged
merged 3 commits into from
Apr 11, 2023
Merged

DOC: Section on RTD version switcher #1280

merged 3 commits into from
Apr 11, 2023

Conversation

VeckoTheGecko
Copy link
Contributor

This clarification confirms this theme supports RTD versioning by default. This is necessary as many users start up with simple projects which may not implement sectioning, which may confuse them as to why the RTD version switcher isn't visible. It reassures its not a bug with their code/docs configuration.

As per discussion at #1005 (comment) . Related to #705

Maintainers feel free to push changes to this branch if desired.

@drammock
Copy link
Collaborator

drammock commented Apr 4, 2023

CIs are failing; it looks like maybe you don't have our pre-commit hooks set up @VeckoTheGecko? See here: https://pydata-sphinx-theme.readthedocs.io/en/latest/community/setup.html#setup-pre-commit

@VeckoTheGecko
Copy link
Contributor Author

Didn't notice the hooks before. Fixed :^)

Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I've rewritten a bit to add more detail.

docs/user_guide/readthedocs.md Outdated Show resolved Hide resolved
docs/user_guide/readthedocs.md Outdated Show resolved Hide resolved
docs/user_guide/readthedocs.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crossref fixed

@drammock drammock merged commit 371126e into pydata:main Apr 11, 2023
@VeckoTheGecko VeckoTheGecko deleted the docs/rtd-section branch April 11, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants