Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix codecov #1289

Merged
merged 7 commits into from
Apr 12, 2023
Merged

try to fix codecov #1289

merged 7 commits into from
Apr 12, 2023

Conversation

drammock
Copy link
Collaborator

hopefully this fixes the CI errors we're seeing in #1278

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me as long as tests are happy!

@drammock
Copy link
Collaborator Author

not yet... I broke the .yaml file again. I think this time it's "no double-quotes in if-expressions"

@drammock
Copy link
Collaborator Author

OK, codecov upload works! https://app.codecov.io/github/pydata/pydata-sphinx-theme/commit/c9f2ca3c78e5c41584811b91a06088111929f2a3

merging once audit CI comes back green.

@drammock drammock merged commit b756152 into pydata:main Apr 12, 2023
@drammock drammock deleted the fix-codecov branch April 12, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants