fix infinite loop again #1364
Merged
fix infinite loop again #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the time and effort put into fixing this!!!! |
|
even though this doesn't fully fix the problem (needs pradyunsg/sphinx-theme-builder#44) I'm going to go ahead and merge it because at least then we can locally benefit from using the PR branch of the upstream project without having to manually tweak the noxfile every time. I'll get notified when pradyunsg/sphinx-theme-builder#44 is merged anyway so I won't easily forget to update the hash when the time comes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1359
needs upstream pradyunsg/sphinx-theme-builder#44 and will need a change to the commit hash in
noxfile.pyonce that is merged.